Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new fields to a fieldmap is faster and involves less code duplication. #334

Merged
merged 27 commits into from
Jan 6, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
118bf65
update node stuff
jonathanstegall Jan 4, 2020
b1a5078
put the fieldset template into the html so it can be cloned. hide it …
jonathanstegall Jan 5, 2020
e39d02d
we can't fail linting over underscores with the way other people's co…
jonathanstegall Jan 5, 2020
8dbe298
always hide the template row
jonathanstegall Jan 5, 2020
78095e0
fix the template row so it works before there is a fieldmap also
jonathanstegall Jan 5, 2020
7719342
deprecate wp object description method; rename to fields for what it …
jonathanstegall Jan 5, 2020
313202b
deprecate the combined method as well
jonathanstegall Jan 5, 2020
edf92ed
allow salesforce_object_fields to be ajax method. filter which attrib…
jonathanstegall Jan 5, 2020
29a7fcf
make adding a new fieldset to the fieldmap driven by a template from …
jonathanstegall Jan 5, 2020
06d658c
allow the script to work on a page refresh. also make sure both objec…
jonathanstegall Jan 5, 2020
8017ff2
never delete that template row though
jonathanstegall Jan 5, 2020
8ac45a6
don't replace on existing fieldmaps
jonathanstegall Jan 5, 2020
af39cb5
convert `post` to `ajax` so we can control the spinners individually
jonathanstegall Jan 5, 2020
000fc54
fix spinner markup. also cleanup comments.
jonathanstegall Jan 5, 2020
6ec64ae
update the comments, combine the script, etc
jonathanstegall Jan 5, 2020
a437542
update the changelog
jonathanstegall Jan 5, 2020
f50a654
fix incorrect colspan
jonathanstegall Jan 5, 2020
3e5e4a5
use iife to combine javascript and prepend it
jonathanstegall Jan 6, 2020
1597ebf
separate javascript into multiple files that get concatenated
jonathanstegall Jan 6, 2020
32bb3fd
better organize scripts
jonathanstegall Jan 6, 2020
5cf8785
eslint
jonathanstegall Jan 6, 2020
e99b143
eslint
jonathanstegall Jan 6, 2020
572f927
move deprecated actions into another method
jonathanstegall Jan 6, 2020
f6be108
more eslint
jonathanstegall Jan 6, 2020
3f4a78b
more eslint
jonathanstegall Jan 6, 2020
5b8200b
more eslint
jonathanstegall Jan 6, 2020
8ccd2f8
spaces and tabs
jonathanstegall Jan 6, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .stylelintrc
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
{
"extends": "stylelint-config-wordpress/scss"
"extends": "stylelint-config-wordpress/scss",
"rules": {
"selector-class-pattern": null
}
}
6 changes: 6 additions & 0 deletions Gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ const cssnano = require('cssnano');
const eslint = require('gulp-eslint');
const fs = require('fs');
const gulp = require('gulp');
const iife = require('gulp-iife');
const imagemin = require('gulp-imagemin');
const packagejson = JSON.parse(fs.readFileSync('./package.json'));
const mqpacker = require( 'css-mqpacker' );
Expand Down Expand Up @@ -88,6 +89,11 @@ function adminscripts() {
.pipe(concat(packagejson.name + '-admin.js')) // Concatenate
.pipe(sourcemaps.write())
.pipe(eslint())
.pipe(iife({
useStrict: false,
params: ['$'],
args: ['jQuery']
}))
.pipe(gulp.dest(config.scripts.dest))
.pipe(browserSync.stream());
}
Expand Down
4 changes: 2 additions & 2 deletions assets/css/object-sync-for-salesforce-admin.css

Large diffs are not rendered by default.

Loading