Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually remove ospec from the main code base #2786

Merged
merged 2 commits into from
Jun 10, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions docs/contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,19 +49,17 @@ To send a pull request:

## I'm submitting a PR. How do I run tests?

Assuming you have forked this repo, you can open the `index.html` file in a module's `tests` folder and look at console output to see only tests for that module, or you can run `ospec/bin/ospec` from the command line to run all tests.
After having run `npm install` (a one-time operation), run `npm run test` from the command line to run all tests.

While testing, you can modify a test to use `o.only(description, test)` instead of `o(description, test)` if you wish to run only a specific test to speed up your debugging experience. Don't forget to remove the `.only` after you're done!

There is no need to `npm install` anything in order to run the test suite, however NodeJS is required to run the test suite from the command line. You do need to `npm install` if you want to lint or get a code coverage report though.



## How do I build Mithril.js?

If all you're trying to do is run examples in the codebase, you don't need to build Mithril.js, you can just open the various html files and things should just work.

To generate the bundled file for testing, run `npm run dev` from the command line. To generate the minified file, run `npm run build`. There is no need to `npm install` anything, but NodeJS is required to run the build scripts.
To generate the bundled file for testing, run `npm run dev` from the command line. To generate the minified file, run `npm run build`.



Expand Down
2 changes: 1 addition & 1 deletion docs/nav-methods.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@
- Optional
- [Stream](stream.md)
- Tooling
- [Ospec](https://github.com/MithrilJS/mithril.js/blob/master/ospec)
- [Ospec](https://github.com/MithrilJS/ospec)
21 changes: 0 additions & 21 deletions ospec/LICENSE

This file was deleted.

Loading