Actually remove ospec from the main code base #2786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barneycarroll
requested review from
barneycarroll
and removed request for
StephanHoyer and
dead-claudia
barneycarroll
suggested changes
Jun 10, 2022
Co-authored-by: Barney Carroll <[email protected]>
barneycarroll
approved these changes
Jun 10, 2022
Merged
|
Uh oh... we should have tagged this I guess for |
It's breaking, hence why I held it back. Also, I'm super glad I asked what would happen if we forgot to tag something... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is still used as a
dev-dependency.Description
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist:
docs/changelog.md