Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added web monetization message to foundation site #7713

Merged
merged 5 commits into from
Oct 29, 2021

Conversation

danielfmiranda
Copy link
Collaborator

@danielfmiranda danielfmiranda commented Oct 28, 2021

Closes #7141
Related PRs/issues #

Link to sample test page: https://foundation-s-7141-web-m-yafyg6.herokuapp.com/en/

Steps to test:

  1. Visit the test environment linked above, and browse around
  2. Note the addition of the new text at the bottom of the page footer
  3. Link should link correctly and behave as expected
  4. Visit the mozfest portion of the testing environment at https://mozfest-foundation-s-7141-web-m-yafyg6.mofostaging.net/en/
  5. Scroll to the footer and note that the new text is NOT there.
  6. If everything is behaving as expected, testing is complete!

@mofodevops mofodevops temporarily deployed to foundation-s-7141-web-m-yafyg6 October 28, 2021 20:03 Inactive
@github-actions
Copy link

This PR introduces visual differences. Click here to inspect the diffs.

@fessehaye
Copy link
Contributor

Agreed with pomax's suggestion but the tailwind classes look correct 👍🏾

@danielfmiranda danielfmiranda temporarily deployed to foundation-s-7141-web-m-yafyg6 October 28, 2021 21:06 Inactive
@github-actions
Copy link

This PR introduces visual differences. Click here to inspect the diffs.

1 similar comment
@github-actions
Copy link

This PR introduces visual differences. Click here to inspect the diffs.

@kristinashu
Copy link

I can approve this for design since Nancy is out today. The design looks great and I will approve it but I just double checked with Anil and the footer link should actually also be on https://mozfest-foundation-s-7141-web-m-yafyg6.mofostaging.net/ and https://foundation-s-7141-web-m-yafyg6.herokuapp.com/privacynotincluded but it can be done as a follow up if that's easier.

@kristinashu kristinashu self-requested a review October 28, 2021 23:25
@danielfmiranda
Copy link
Collaborator Author

Thanks @kristinashu!

@Pomax does that mean I should remove the flag for displaying the monetization text and just display it on pni/mozfest/mofo-site?

@danielfmiranda danielfmiranda temporarily deployed to foundation-s-7141-web-m-yafyg6 October 29, 2021 18:51 Inactive
@danielfmiranda danielfmiranda temporarily deployed to foundation-s-7141-web-m-yafyg6 October 29, 2021 18:58 Inactive
@github-actions
Copy link

This PR introduces visual differences. Click here to inspect the diffs.

2 similar comments
@github-actions
Copy link

This PR introduces visual differences. Click here to inspect the diffs.

@github-actions
Copy link

This PR introduces visual differences. Click here to inspect the diffs.

@danielfmiranda danielfmiranda changed the title added web monetization message to foundation site, not showing on mozfest added web monetization message to foundation site Oct 29, 2021
@danielfmiranda
Copy link
Collaborator Author

Per request of Kristina, we now made the new monetization message display on all pages of the foundation site including Mozfest and PNI.

@danielfmiranda danielfmiranda merged commit 2cf8ef0 into main Oct 29, 2021
@danielfmiranda danielfmiranda deleted the 7141-web-monetization-note branch October 29, 2021 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Due 10/29] Add section to footer to include Web Monetization note
5 participants