Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default error rate for Illumina #133

Closed
mbhall88 opened this issue Jul 11, 2021 · 0 comments · Fixed by #144
Closed

Default error rate for Illumina #133

mbhall88 opened this issue Jul 11, 2021 · 0 comments · Fixed by #144

Comments

@mbhall88
Copy link
Member

I'm wondering where the default error rate (for Illumina) of 0.05 (5%) comes from? That is awfully high for Illumina - most sources I read (and pandora) use something more like 0.001 (0.1%).

mykrobe/src/mykrobe/base.py

Lines 124 to 130 in 59dfb97

genotyping_mixin.add_argument(
"-e",
"--expected_error_rate",
help="Expected sequencing error rate (default: %(default).2f)",
default=0.05,
type=float,
)

While working on mbhall88/head_to_head_pipeline#76 I tried out lowering the error rate to 0.001. It didn't have a huge impact, but all the differences were positive. We recovered one FN for Ethambutol and one FN for Rifampicin.

@martinghunt I wonder if you played with the error rate when doing the analysis for the recent paper? If not, how easy would it be to rerun it with this lowered error rate to see the impact on a bigger dataset?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant