Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Nanopore defaults #144

Merged
merged 14 commits into from
Feb 1, 2022
Merged

Conversation

mbhall88
Copy link
Member

Changed

Note: this branch is based off the tip of #138, so once that PR is merged, this PR will be simplified down to the last 2 commits.

@martinghunt
Copy link
Member

I vote definitely change all the nanopore defaults.

I'd prefer to rerun the mykrobe paper data before changing any illumina defaults.

@mbhall88
Copy link
Member Author

mbhall88 commented Dec 1, 2021

I vote definitely change all the nanopore defaults.

I'd prefer to rerun the mykrobe paper data before changing any illumina defaults.

Ok, I have changed the Illumina error rate back to 0.05.

It seems strange though given this

if args.guess_sequence_method and kmer_count_error_rate > 0.001:
logger.warning("Guess sequence method is on, and we've guessed ONT")
args.ont = True

we seem to acknowledge that anything with an error rate over 0.001 is not Illumina, but set the expected error rate for Illumina to 0.05...

@mbhall88 mbhall88 merged commit 14621ad into Mykrobe-tools:master Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ONT flag default settings Default error rate for Illumina
2 participants