-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Nanopore defaults #144
Conversation
I vote definitely change all the nanopore defaults. I'd prefer to rerun the mykrobe paper data before changing any illumina defaults. |
Ok, I have changed the Illumina error rate back to 0.05. It seems strange though given this mykrobe/src/mykrobe/cmds/amr.py Lines 340 to 342 in b4a19c2
we seem to acknowledge that anything with an error rate over 0.001 is not Illumina, but set the expected error rate for Illumina to 0.05... |
Changed
--ont
defaults to an expected error rate of 0.08 and ploidy'haploid' [closes ONT flag default settings #134]
Note: this branch is based off the tip of #138, so once that PR is merged, this PR will be simplified down to the last 2 commits.