Skip to content

Commit

Permalink
pick(rest): discard failed dynamic field indices (#19379)
Browse files Browse the repository at this point in the history
## Description

Allow dynamic field indexing to fail when building up fullnode REST
indices to bring it in line with behaviour in `sui-indexer`,
`sui-analytics-indexer`, and the existing fullnode indices.

## Test plan

CI

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] Indexer: 
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:
- [ ] REST API:
  • Loading branch information
amnn authored Sep 15, 2024
1 parent 25eb251 commit 776118a
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion crates/sui-core/src/rest_index.rs
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,9 @@ impl IndexStoreTables {
}
Owner::ObjectOwner(parent) => {
if let Some(field_info) =
try_create_dynamic_field_info(object, resolver)?
try_create_dynamic_field_info(object, resolver)
.ok()
.flatten()
{
let field_key = DynamicFieldKey::new(*parent, object.id());

Expand Down

0 comments on commit 776118a

Please sign in to comment.