Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pick(rest): discard failed dynamic field indices #19379

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

amnn
Copy link
Member

@amnn amnn commented Sep 14, 2024

Description

Allow dynamic field indexing to fail when building up fullnode REST indices to bring it in line with behaviour in sui-indexer, sui-analytics-indexer, and the existing fullnode indices.

Test plan

CI


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

## Description

Allow dynamic field indexing to fail when building up fullnode REST
indices to bring it in line with behaviour in `sui-indexer`,
`sui-analytics-indexer`, and the existing fullnode indices.

## Test plan

CI
@amnn amnn self-assigned this Sep 14, 2024
Copy link

vercel bot commented Sep 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2024 11:19pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Sep 14, 2024 11:19pm
sui-kiosk ⬜️ Ignored (Inspect) Sep 14, 2024 11:19pm
sui-typescript-docs ⬜️ Ignored (Inspect) Sep 14, 2024 11:19pm

Copy link
Contributor

@dariorussi dariorussi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@amnn amnn merged commit 776118a into releases/sui-v1.33.0-release Sep 15, 2024
48 of 49 checks passed
@amnn amnn deleted the amnn/pick-1.33-rest-df branch September 15, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants