[bridge 48/n] types: introduce a few more constants and move things to sui-types/bridge.rs #16380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longbowlu
requested review from
lxfind,
tnowacki,
patrickkuo,
tzakian,
Bridgerz,
mwtian and
dariorussi
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mwtian
approved these changes
Feb 29, 2024
longbowlu
force-pushed
the
fb-bridge-47-updates-to-limiter
branch
from
b6c439f
to
de1006f
Compare
longbowlu
requested review from
amnn,
wlmyng,
stefan-mysten,
emmazzz,
suiwombat and
ronny-mysten
as code owners
Base automatically changed from
fb-bridge-47-updates-to-limiter
to
feature/native-bridge
March 5, 2024 01:09
patrickkuo
force-pushed
the
feature/native-bridge
branch
from
ad1ebde
to
a78cee2
Compare
patrickkuo
force-pushed
the
feature/native-bridge
branch
4 times, most recently
from
bf4f562
to
53ef179
Compare
patrickkuo
pushed a commit
that referenced
this pull request
May 2, 2024
…o sui-types/bridge.rs (#16380) ## Description 1, introduce a few more constants and move things to sui-types/bridge.rs 2, relax the total voting power = 10k requirement, in case of not all validators opt in. ## Test Plan How did you test the new or updated feature? --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
patrickkuo
pushed a commit
that referenced
this pull request
May 8, 2024
…o sui-types/bridge.rs (#16380) ## Description 1, introduce a few more constants and move things to sui-types/bridge.rs 2, relax the total voting power = 10k requirement, in case of not all validators opt in. ## Test Plan How did you test the new or updated feature? --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
patrickkuo
pushed a commit
that referenced
this pull request
May 9, 2024
…o sui-types/bridge.rs (#16380) ## Description 1, introduce a few more constants and move things to sui-types/bridge.rs 2, relax the total voting power = 10k requirement, in case of not all validators opt in. ## Test Plan How did you test the new or updated feature? --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
patrickkuo
pushed a commit
that referenced
this pull request
May 9, 2024
…o sui-types/bridge.rs (#16380) ## Description 1, introduce a few more constants and move things to sui-types/bridge.rs 2, relax the total voting power = 10k requirement, in case of not all validators opt in. ## Test Plan How did you test the new or updated feature? --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
patrickkuo
pushed a commit
that referenced
this pull request
May 9, 2024
…o sui-types/bridge.rs (#16380) ## Description 1, introduce a few more constants and move things to sui-types/bridge.rs 2, relax the total voting power = 10k requirement, in case of not all validators opt in. ## Test Plan How did you test the new or updated feature? --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
patrickkuo
pushed a commit
that referenced
this pull request
May 9, 2024
…o sui-types/bridge.rs (#16380) ## Description 1, introduce a few more constants and move things to sui-types/bridge.rs 2, relax the total voting power = 10k requirement, in case of not all validators opt in. ## Test Plan How did you test the new or updated feature? --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1, introduce a few more constants and move things to sui-types/bridge.rs
2, relax the total voting power = 10k requirement, in case of not all validators opt in.
Test Plan
How did you test the new or updated feature?
If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section.
Type of Change (Check all that apply)
Release notes