[bridge] refactor test utils #17288
Merged
[bridge] refactor test utils #17288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
longbowlu
requested review from
lxfind,
patrickkuo,
Bridgerz,
mwtian,
mystenmark and
dariorussi
Bridgerz
reviewed
Apr 24, 2024
| } | ||
| } | ||
|
|
||
| impl BridgeTestClusterBuilder { |
dariorussi
approved these changes
Apr 25, 2024
| } | ||
|
|
||
| pub fn sui_client(&self) -> SuiClient { | ||
| self.test_cluster.fullnode_handle.sui_client.clone() |
There was a problem hiding this comment.
I suppose we could clone on the caller side and return a reference?
| } | ||
|
|
||
| pub fn bridge_authority_key(&self, index: usize) -> BridgeAuthorityKeyPair { | ||
| self.test_cluster.bridge_authority_keys.as_ref().unwrap()[index].copy() |
| } | ||
|
|
||
| pub fn sui_rpc_url(&self) -> String { | ||
| self.test_cluster.fullnode_handle.rpc_url.clone() |
| } | ||
|
|
||
| pub fn eth_rpc_url(&self) -> String { | ||
| self.eth_environment.rpc_url.clone() |
patrickkuo
pushed a commit
that referenced
this pull request
May 2, 2024
## Description This PR: 1. refactors e2e test utils by introducing `BridgeTestClusterBuilder` and `BridgeTestCluster` 2. enables the ability to drop spawned BridgeNodes, and restart them (not in this PR, but this PR makes it easy to do) 3. speeds up the setup by doing things in parallel. This probably cuts at least 20 seconds for each test. ## Test plan existing tests --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
patrickkuo
pushed a commit
that referenced
this pull request
May 8, 2024
## Description This PR: 1. refactors e2e test utils by introducing `BridgeTestClusterBuilder` and `BridgeTestCluster` 2. enables the ability to drop spawned BridgeNodes, and restart them (not in this PR, but this PR makes it easy to do) 3. speeds up the setup by doing things in parallel. This probably cuts at least 20 seconds for each test. ## Test plan existing tests --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
patrickkuo
pushed a commit
that referenced
this pull request
May 9, 2024
## Description This PR: 1. refactors e2e test utils by introducing `BridgeTestClusterBuilder` and `BridgeTestCluster` 2. enables the ability to drop spawned BridgeNodes, and restart them (not in this PR, but this PR makes it easy to do) 3. speeds up the setup by doing things in parallel. This probably cuts at least 20 seconds for each test. ## Test plan existing tests --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
patrickkuo
pushed a commit
that referenced
this pull request
May 9, 2024
## Description This PR: 1. refactors e2e test utils by introducing `BridgeTestClusterBuilder` and `BridgeTestCluster` 2. enables the ability to drop spawned BridgeNodes, and restart them (not in this PR, but this PR makes it easy to do) 3. speeds up the setup by doing things in parallel. This probably cuts at least 20 seconds for each test. ## Test plan existing tests --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
patrickkuo
pushed a commit
that referenced
this pull request
May 9, 2024
## Description This PR: 1. refactors e2e test utils by introducing `BridgeTestClusterBuilder` and `BridgeTestCluster` 2. enables the ability to drop spawned BridgeNodes, and restart them (not in this PR, but this PR makes it easy to do) 3. speeds up the setup by doing things in parallel. This probably cuts at least 20 seconds for each test. ## Test plan existing tests --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
patrickkuo
pushed a commit
that referenced
this pull request
May 9, 2024
## Description This PR: 1. refactors e2e test utils by introducing `BridgeTestClusterBuilder` and `BridgeTestCluster` 2. enables the ability to drop spawned BridgeNodes, and restart them (not in this PR, but this PR makes it easy to do) 3. speeds up the setup by doing things in parallel. This probably cuts at least 20 seconds for each test. ## Test plan existing tests --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
BridgeTestClusterBuilderandBridgeTestClusterTest plan
existing tests
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.