[Fastpath] Support transactions certified through consensus #19601
+62
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
mwtian
force-pushed
the
tmw/transaction-cert
branch
from
9933980
to
7382a74
Compare
mwtian
changed the title
mwtian
changed the title
mwtian
requested review from
lxfind,
aschran,
akichidis,
arun-koshy and
mystenmark
mwtian
force-pushed
the
tmw/transaction-cert
branch
from
7382a74
to
6e08480
Compare
akichidis
approved these changes
Sep 30, 2024
aschran
approved these changes
Sep 30, 2024
| pub type TransactionIndex = u16; | ||
|
|
||
| /// Consensus timestamp in ms. | ||
| pub type ConsensusTimestampMs = u64; |
There was a problem hiding this comment.
can we be consistent about whether or not we are prefixing consensus-related type aliases with Consensus?
that is to say, should it be removed here or added on the types above?
There was a problem hiding this comment.
I was trying to avoid confusion with CheckpointTimestamp or other timestamp types. But looking at how the Narwhal imported TimestampMs type is used without issue, I will leave this as TimestampMs for now.
mwtian
requested review from
amnn,
wlmyng,
stefan-mysten,
emmazzz and
suiwombat
as code owners
mwtian
force-pushed
the
tmw/transaction-cert
branch
from
10434de
to
b321dd1
Compare
mwtian
removed request for
amnn,
emmazzz,
suiwombat,
wlmyng and
stefan-mysten
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The fields in the
CertificateProof::Consensusvariant is chosen to enhance debuggability (including the transaction's position in the DAG: round, authority index, transaction index), without unnecessary data (consensus block digest is excluded).Test plan
CI
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.