Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set server.plugins value to valid value #216

Closed
MJJoyce opened this issue Oct 14, 2019 · 0 comments · Fixed by #218
Closed

Set server.plugins value to valid value #216

MJJoyce opened this issue Oct 14, 2019 · 0 comments · Fixed by #218
Assignees

Comments

@MJJoyce
Copy link
Member

MJJoyce commented Oct 14, 2019

The default value provided for server.plugins in config.yaml is resulting in an unexpected None in some checks. While this one again brings up the idea of checking for defaults / expected values on an initial config load and warning appropriately, it's easier in the near term to make sure that if we set the value that it's valid.

The specific example where this is causing problems:

Our current server.config value

    server:
        plugins:

The code in GUI that is pulling this value breaks when server.plugins exists but isn't a valid form

        plugins = ait.config.get('server.plugins', [])
        for i in range(len(plugins)):

Removing server.plugins or setting it to an empty list fixes this problem.

@MJJoyce MJJoyce self-assigned this Oct 14, 2019
MJJoyce added a commit that referenced this issue Oct 14, 2019
Issue #216 - Update server.plugins default value in config to an empty
list so it doesn't fall back to None. This prevents it from breaking
other code that checks if the value exists and falls back to a sane
default if it doesn't.

Issue #217 - Handler class path wasn't updated as part of the changes in
issue #214.
MJJoyce added a commit that referenced this issue Oct 18, 2019
Issue #216 and #217 - Fix default plugins and handler package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant