Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example handler in config doesn't exist #217

Closed
MJJoyce opened this issue Oct 14, 2019 · 0 comments · Fixed by #218
Closed

Example handler in config doesn't exist #217

MJJoyce opened this issue Oct 14, 2019 · 0 comments · Fixed by #218
Assignees
@MJJoyce

Comments

@MJJoyce
Copy link
Member

MJJoyce commented Oct 14, 2019

Forgot to update the config when making package changes in #214 so the handler now fails to import.

- name: ait.core.server.handler.PacketHandler
@MJJoyce MJJoyce self-assigned this Oct 14, 2019
MJJoyce added a commit that referenced this issue Oct 14, 2019
@MJJoyce
Issue #216 and #217 - Fix default plugins and handler package
af71583 
Issue #216 - Update server.plugins default value in config to an empty
list so it doesn't fall back to None. This prevents it from breaking
other code that checks if the value exists and falls back to a sane
default if it doesn't.

Issue #217 - Handler class path wasn't updated as part of the changes in
issue #214.
@MJJoyce MJJoyce mentioned this issue Oct 14, 2019
Merged
MJJoyce added a commit that referenced this issue Oct 18, 2019
@MJJoyce
Merge pull request #218 from NASA-AMMOS/issue-216
cb0fccf 
Issue #216 and #217 - Fix default plugins and handler package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MJJoyce MJJoyce

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #216 and #217 - Fix default plugins and handler package NASA-AMMOS/AIT-Core
1 participant
@MJJoyce