Issue #33 - Switch BLISS naming to AIT #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorsposto
reviewed
May 4, 2018
doc/source/configuration_intro.rst
Outdated
| name: bliss | ||
| hostname: bliss.jpl.nasa.gov | ||
| name: ait | ||
| hostname: ait.jpl.nasa.gov |
There was a problem hiding this comment.
Need to replace hostname like this line?
lorsposto
reviewed
May 4, 2018
doc/source/contribute.rst
Outdated
| @@ -93,10 +93,10 @@ AIT makes a best-effort attempt at sticking with PEP-8 conventions. | |||
| Mailing Lists | |||
| ------------- | |||
|
|
|||
| The AIT mailings lists are a good way to get in contact with people working on the project. If you need help with something on the project feel free to send an email to the AIT team at **bliss[email protected]**. | |||
| The AIT mailings lists are a good way to get in contact with people working on the project. If you need help with something on the project feel free to send an email to the AIT team at **ait[email protected]**. | |||
There was a problem hiding this comment.
We'll need to update the mailing list email
lorsposto
reviewed
May 4, 2018
doc/source/developer_info.rst
Outdated
|
|
||
| * Major bumps are for large, non-backwards compatible changes | ||
| * Minor bumps are for backwards compatible changes | ||
| * Patch bumps are for incremental bug fixes, small releases, and end-of-sprint releases. | ||
|
|
||
| 2. *Update the project documentation to use the correct version names.* The following files needs to be updated with the correct version names: | ||
|
|
||
| * `doc/source/conf.py <https://github.jpl.nasa.gov/bliss/bliss-core/blob/master/doc/source/conf.py>`_ - contains a **version** and **release** option. Both of these should be updated to point to the version number for this release. | ||
| * `doc/source/conf.py <https://github.jpl.nasa.gov/ait/ait-core/blob/master/doc/source/conf.py>`_ - contains a **version** and **release** option. Both of these should be updated to point to the version number for this release. |
lorsposto
reviewed
May 4, 2018
doc/source/installation.rst
Outdated
| @@ -17,8 +17,8 @@ Clone the repository from JPL Github: | |||
|
|
|||
| .. code-block:: bash | |||
|
|
|||
| $ git clone https://github.jpl.nasa.gov/bliss/bliss-core.git | |||
| $ cd bliss-core | |||
| $ git clone https://github.jpl.nasa.gov/ait/ait-core.git | |||
There was a problem hiding this comment.
github.j.n.g should be replaced with public GH url, which will help #44.
lorsposto
reviewed
May 4, 2018
doc/source/installation.rst
Outdated
|
|
||
| .. code-block:: bash | ||
|
|
||
| $ pip install bliss-core --extra-index-url https://bliss.jpl.nasa.gov/pypi/simple/ | ||
| $ pip install ait-core --extra-index-url https://ait.jpl.nasa.gov/pypi/simple/ |
There was a problem hiding this comment.
Should remove the reference to j.n.g. We can update the pip install command to install from public PyPi; we will have to update the publish the package as ait-core so that pip install ait-core will work. Will help #44
lorsposto
reviewed
May 4, 2018
doc/source/installation.rst
Outdated
| @@ -145,4 +145,4 @@ Run the following to upgrade to the latest AIT Core versions. | |||
|
|
|||
| .. code-block:: bash | |||
|
|
|||
| $ pip install bliss-core --extra-index-url https://bliss.jpl.nasa.gov/pypi/simple/ --upgrade | |||
| $ pip install ait-core --extra-index-url https://ait.jpl.nasa.gov/pypi/simple/ --upgrade | |||
There was a problem hiding this comment.
Same as above re: installation from public PyPi.
lorsposto
reviewed
May 4, 2018
doc/source/project_setup.rst
Outdated
| @@ -12,18 +12,18 @@ If you use a requirements file for specifying dependencies: | |||
|
|
|||
| .. code-block:: bash | |||
|
|
|||
| --extra-index-url https://bliss.jpl.nasa.gov/pypi/simple/ | |||
| bliss-core==1.0.0 | |||
| --extra-index-url https://ait.jpl.nasa.gov/pypi/simple/ | |||
There was a problem hiding this comment.
Can remove the j.n.g reference.
|
Thanks @lorsposto! Updated with your change requests. |
lorsposto
approved these changes
May 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review this carefully folks. Obviously this is a massive amount of changes in here.
@lorsposto I'll probably need you to look at the PyPi related stuff since I'm not terribly familiar with it at the moment.
Resolve #33