-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As a developer I want a consistent use of requirements.txt and install_requires across repos #21
Comments
@nutjob4life, I know we chatted about this a bit on Slack. If you think I'm missing some of the take aways there please let me know |
I would love to see Especially now as the trend is to put everything into one file, |
@nutjob4life let's do it. down with requirements.txt is fine with me. |
Note, I forgot to mention it but since it's related ... We should probably put in a |
Move template repo over to setup.cfg for package metadata management and pyproject.toml for up-to-date build system management. Development dependencies are now grouped under `extras_require.dev` and `requirements.txt` has been dropped. Resolve #21
Move template repo over to setup.cfg for package metadata management and pyproject.toml for up-to-date build system management. Development dependencies are now grouped under `extras_require.dev` and `requirements.txt` has been dropped. Resolve #21
Move template repo over to setup.cfg for package metadata management and pyproject.toml for up-to-date build system management. Development dependencies are now grouped under `extras_require.dev` and `requirements.txt` has been dropped. Resolve #21
Issue #21 - Move install to setup.cfg and pyproject.toml
💪 Motivation
Our current use of
requirements.txt
somewhat blurs the line betweenrequirements.txt
andinstall_requires
in our template repo. This can be confusing and result in devs / teams applying unique (and occasionally unnecessary) solutions that lead to further inconsistencies across repositories.📖 Additional Details
PyPA has the the following to say on these options.
⚙️ Engineering Details
Our current
setup.py
reads everything fromrequirements.txt
and shoves it intoinstall_requires
. Since they're currently duplicates of each other I'd suggest that we baseline on a few things:install_requires
should specify what the project minimally needs to run correctly per the PyPA recommendations. This should be explicit and not hidden in another file.extra_requires
should be used to handle non-critical dev dependencies under thedev
"keyword". This should also be explicit and not hidden in another file.requirements.txt
around (and really confuse people) we can specify that it should install the package in editable mode with thedev
extra_requires
. I'd argue that it's not really needed in the majority of cases as is and we could just drop it entirely from the template repo.The text was updated successfully, but these errors were encountered: