Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #20 - Add developer tools to template project #24

Merged
merged 2 commits into from
Aug 9, 2021
Merged

Conversation

MJJoyce
Copy link
Contributor

@MJJoyce MJJoyce commented Aug 6, 2021

Summary*
Add black, flake8 (and some plugins), and mypy to python template repo
along with some hopefully sane default configuration. Update README to
point users at setup.cfg instead of setup.py and elaborate on dev
tool use.

Clean our template files so they pass black, flake8, and mypy without
errors / warnings.

Resolve #20

Test Data and/or Report
Tools run clean on our repo now:

(pds-template-repo-python) > $ black src                                                                                                                                                       
All done! ✨ 🍰 ✨
3 files left unchanged.

(pds-template-repo-python) > $ flake8 src                                                                                                                                                      

(pds-template-repo-python) > $ mypy src                                                                                                                                                        
Success: no issues found in 3 source files

@MJJoyce
Copy link
Contributor Author

MJJoyce commented Aug 6, 2021

Note, this has 8987ecd from #21 since it depends on it. I'll rebase that out if necessary once #21 is merged.

Add black, flake8 (and some plugins), and mypy to python template repo
along with some hopefully sane default configuration. Update README to
point users at `setup.cfg` instead of `setup.py` and elaborate on dev
tool use.
Clean our template files so they pass black, flake8, and mypy without
errors / warnings.
@@ -4,3 +4,6 @@ requires = ["setuptools >= 46.4.0", "wheel"]
# uncomment to enable pep517 after versioneer problem is fixed.
# https://github.com/python-versioneer/python-versioneer/issues/193
#build-backend = "setuptools.build_meta"

[tool.black]
line-length = 120
Copy link
Member

@nutjob4life nutjob4life Aug 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do appreciate this! 🦸

Copy link
Member

@nutjob4life nutjob4life left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fabulous. 🚢 it.

@MJJoyce MJJoyce merged commit 05317c8 into main Aug 9, 2021
@MJJoyce MJJoyce deleted the issue-20 branch August 9, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a developer I want integration of linters and code formatters to the default template repos
2 participants