Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix builds for conda-forge #415

Closed
bekozi opened this issue Apr 4, 2016 · 4 comments
Closed

Fix builds for conda-forge #415

bekozi opened this issue Apr 4, 2016 · 4 comments
Assignees
@bekozi
Labels
bug
Milestone
v1.3.1

Comments

@bekozi
Copy link
Contributor

bekozi commented Apr 4, 2016

@ocefpaf has migrated the IOOS recipes to conda-forge. There are some outstanding test failures on the new CI. See conda-forge/staged-recipes#159.
@bekozi bekozi self-assigned this Apr 4, 2016
@bekozi bekozi added this to the v1.4.0 milestone Apr 4, 2016
@bekozi
Copy link
Contributor Author

bekozi commented Apr 6, 2016

Test failures are related to masked array changes innumpy v1.11. The changes only affected some tests checking NetCDF file equality. Need to tag a new bug fix release.

@bekozi bekozi modified the milestones: v1.3.1, v1.4.0 Apr 6, 2016
@bekozi bekozi added bug and removed enhancement labels Apr 6, 2016
bekozi added a commit that referenced this issue Apr 6, 2016
@bekozi
FIX: Modified equality testing for dimensionless variables #415
719d156
@bekozi
Copy link
Contributor Author

bekozi commented Apr 6, 2016

@ocefpaf, could you retry conda-forge builds using the ocgis branch i415-conda-forge? I'm not quite sure how to navigate the PR chain. It'd be nice to fix any other issues on this before tagging. Thank you!

@ocefpaf
Copy link

ocefpaf commented Apr 6, 2016

Sure. Hold on...

bekozi added a commit that referenced this issue Apr 13, 2016
@bekozi
FIX: Fix builds for conda-forge #415
ef471a8 
- Fixed testing of dimensionless variable values when comparing
netCDF files due to changes in NumPy v1.11.
- Modified search for windows environment looking for GDAL_DATA
@bekozi
Copy link
Contributor Author

bekozi commented Apr 13, 2016

Merged to master.

@bekozi bekozi closed this as completed Apr 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bekozi bekozi

Labels
bug
Projects
None yet
Milestone
v1.3.1
Development

No branches or pull requests
2 participants
@bekozi @ocefpaf