ocgis #159

ocefpaf · 2016-03-19T16:38:45Z

Ping @bekozi.

~~PS: I believe we have to tweak the gdal recipe.~~

~~Edit: This PR needs #158~~

pelson · 2016-03-22T17:30:17Z

Seems like there are a few test issues with this one.

ocefpaf · 2016-03-22T17:31:22Z

I need to get back to this one at a later time. I will close it for now to reduce the noise here.

pelson · 2016-03-22T17:32:11Z

I need to get back to this one at a later time. I will close it for now to reduce the noise here.

It's fine. I suspect this repo will never be free of noise - that is the nature of lots of timezones and day jobs. 😄

conda-forge-admin · 2016-04-01T16:20:33Z

Hi! This is the friendly conda-forge-admin automated user.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ocgis) and found it was in an excellent condition.

conda-forge-admin · 2016-04-02T14:15:01Z

Hi! This is the friendly conda-forge-admin automated user.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/ocgis) and found some lint.

Here's what I've got...

For recipes/ocgis:

Selectors are suggested to take a <space><space>#<space>[<selector>] form.

pelson · 2016-04-02T14:21:56Z

Selectors are suggested to take a #[] form.

really is ugly trying to render the fact that it should be a leading double space " # [selector]"

conda-forge-admin · 2016-04-02T14:31:21Z

Hi! This is the friendly conda-forge-admin automated user.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ocgis) and found it was in an excellent condition.

ocefpaf · 2016-04-02T14:31:42Z

❤️ the new label!

pelson · 2016-04-02T14:34:42Z

❤️ the new label!

Hehe, that was me trying to get the linting service to recognise your bad selector 😜

ocefpaf · 2016-04-06T19:43:49Z

Ping @bekozi . (Re-building from that branch.)

bekozi · 2016-04-06T20:59:20Z

@ocefpaf, the failures on osx and windows are both related to gdal linking. For osx, the gdal shared library cannot be found by fiona:

===== testing package: ocgis-1.3.0-py27_0 =====
import: 'ocgis'
Traceback (most recent call last):
  File "/Users/travis/miniconda/conda-bld/test-tmp_dir/run_test.py", line 25, in <module>
    import ocgis
  File "/Users/travis/miniconda/envs/_test/lib/python2.7/site-packages/ocgis/__init__.py", line 1, in <module>
    from ocgis.util.environment import env
  File "/Users/travis/miniconda/envs/_test/lib/python2.7/site-packages/ocgis/util/environment.py", line 10, in <module>
    from ocgis.util.helpers import get_iter
  File "/Users/travis/miniconda/envs/_test/lib/python2.7/site-packages/ocgis/util/helpers.py", line 10, in <module>
    import fiona
  File "/Users/travis/miniconda/envs/_test/lib/python2.7/site-packages/fiona/__init__.py", line 72, in <module>
    from fiona.collection import Collection, BytesCollection, vsi_path
  File "/Users/travis/miniconda/envs/_test/lib/python2.7/site-packages/fiona/collection.py", line 7, in <module>
    from fiona.ogrext import Iterator, ItemsIterator, KeysIterator
ImportError: dlopen(/Users/travis/miniconda/envs/_test/lib/python2.7/site-packages/fiona/ogrext.so, 2): Library not loaded: /usr/local/lib/libgeotiff.2.dylib
  Referenced from: /Users/travis/miniconda/envs/_test/lib/libgdal.1.dylib
  Reason: image not found
TESTS FAILED: ocgis-1.3.0-py27_0

For windows, the issue is GDAL_DATA again. However, this looks like something I may be available to fix. Do you think the environment variable is appropriately set on the windows builds? I remember you saying that is was most likely fixed.

ocefpaf · 2016-04-06T21:04:29Z

@ocefpaf, the failures on osx and windows are both related to gdal linking. For osx, the gdal shared library cannot be found by fiona:

I just rebased this PR because we are removing homebrew from Travis-CI now (and I forgot to do that here). That should fix gdal/fiona issues.

Do you think the environment variable is appropriately set on the windows builds? I remember you saying that is was most likely fixed.

I need to check that again. I will get back to you.

ocefpaf · 2016-04-06T21:38:26Z

The failures have nothing to do with this PR. I am preparing a new gdal that should fix this.

ocefpaf · 2016-04-08T11:02:00Z

Ping @bekozi. Things are green on OS X and Linux now. The Windows failure is the GDAL folder issue.

Here is how we call the activate script and here is the script. Let me know if you can see any obvious errors and/or if that could be fixed in ocgis.

bekozi · 2016-04-08T15:09:57Z

Thanks @ocefpaf. I'll take a look.

ocefpaf · 2016-04-08T17:15:43Z

recipes/ocgis/run_test.py

+if 'LIBRARY_PREFIX' in os.environ:  # Windows.
+    gdalData = os.path.join(os.environ['LIBRARY_PREFIX'], 'share', 'gdal')
+else:  # Linux/OS X.
+    gdalData = os.path.join(os.environ['PREFIX'], 'share', 'gdal')


@bekozi this is the trick we do in gdal. In theory that var will be available in normal envs, not sure why it does not work on the _test env. Can ocgis use that var?

@ocefpaf, this should be usable. I can add it to the bag of tricks used to find the GDAL_DATA directory. Thanks for the snippet. I'll do some testing on my end.

We are leaking GDAL implementation detail into this recipe, which isn't ideal. Maybe we can come up with a better solution in GDAL?

I've raised an issue in conda-forge/gdal-feedstock#35.

Don't let it hold this PR up though - we can always go back and remove it!

@ocefpaf, this should be good to go with the v1.3.1 tag!

@pelson, I'm not enamored with the solution either. I'd love to find an alternative.

@ocefpaf, this should be good to go with the v1.3.1 tag!

Rebased, updated, and waiting for the green.

Thanks @bekozi!

bekozi · 2016-04-12T21:36:41Z

@ocefpaf, we can retry these builds. Hopefully for the last time. 😄 I made a change to the path search for windows and was able to build successfully on linux and windows locally. You can revert run_test.py to:

from ocgis.test import run_simple

run_simple()

The GDAL_DATA path moved with the new build, so I added another search option. The reason it wasn't working with your test file changes was that the environment variable was set below the ocgis import. However, we should be able to avoid this now!

bekozi · 2016-04-12T21:37:23Z

We'll need to wait for the bug fix version before merging of course...

ocefpaf · 2016-04-12T21:38:40Z

recipes/ocgis/meta.yaml

+source:
+    git_url: https://github.com/NCPP/ocgis.git
+    #git_tag: v{{ version }}
+    git_tag: i415-conda-forge


I re-started the CIs. If that works do you plan on a new release or do you want to make the conda package using this branch for a while? (That is fine if you have reasons to do so.)

There are a couple other bugs so I don't mind tagging one. Will take a day or so.

No rush. We can wait for good software.

ocefpaf · 2016-04-12T22:09:00Z

And we have green! 🎉

jakirkham · 2016-04-12T22:22:34Z

So, I guess we are waiting for a new release. Correct?

bekozi · 2016-04-12T22:31:00Z

Excellent! @jakirkham, yes, I'll tag one in the near-term and report back here when it's ready.

pelson · 2016-04-13T16:19:44Z

recipes/ocgis/bld.bat

@@ -0,0 +1,2 @@
+"%PYTHON%" setup.py install --single-version-externally-managed --record record.txt


We don't need this file anymore 😄

Happy to remove it!

ocefpaf · 2016-04-18T23:08:04Z

ocgis is fine. The failures are due to a sequence of updates that were not "digested well" by gdal. I am working to get gdal (fiona and rasterio) working again so we can merge this.

conda-forge-linter · 2016-04-21T00:36:31Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ocgis) and found it was in an excellent condition.

ocefpaf · 2016-04-21T00:47:07Z

@bekozi the fiona issue was solved and I re-started the CIs, but now we have some unitests that are failing: https://circleci.com/gh/conda-forge/staged-recipes/2322

bekozi · 2016-04-21T00:52:41Z

@ocefpaf it looks like the version in the recipe needs to be incremented to 1.3.1. Those failures should be fixed.

ocefpaf · 2016-04-21T01:04:24Z

@ocefpaf it looks like the version in the recipe needs to be incremented to 1.3.1. Those failures should be fixed.

Done! (I will be out of office for a few days. If this is green bug @pelson to merge it)

jakirkham · 2016-04-21T01:24:53Z

Have a nice holiday, @ocefpaf.

bekozi · 2016-04-21T14:10:49Z

Thanks, all! 😄

jakirkham · 2016-04-21T14:22:04Z

Figured we should drop the WIP. 😉

ocefpaf · 2016-04-24T21:38:06Z

🎉

ocefpaf self-assigned this Mar 20, 2016

pelson changed the title ~~ocgis~~ WIP: ocgis Mar 22, 2016

ocefpaf closed this Mar 22, 2016

ocefpaf reopened this Apr 1, 2016

pelson added Work in progress - don't review yet in progress labels Apr 2, 2016

ocefpaf force-pushed the ocgis branch from 19e62d6 to 0637c88 Compare April 2, 2016 14:31

bekozi mentioned this pull request Apr 4, 2016

Fix builds for conda-forge NCPP/ocgis#415

Closed

ocefpaf force-pushed the ocgis branch from 0637c88 to f32f8fb Compare April 6, 2016 19:42

ocefpaf force-pushed the ocgis branch from f32f8fb to 80c6152 Compare April 6, 2016 21:04

ocefpaf removed the Work in progress - don't review yet label Apr 8, 2016

ocefpaf reviewed Apr 8, 2016
View reviewed changes

ocefpaf reviewed Apr 12, 2016
View reviewed changes

pelson reviewed Apr 13, 2016
View reviewed changes

ocefpaf force-pushed the ocgis branch 2 times, most recently from ee55c09 to a7043a9 Compare April 18, 2016 23:00

ocefpaf force-pushed the ocgis branch from a7043a9 to 62a768a Compare April 21, 2016 00:49

ocefpaf force-pushed the ocgis branch from 62a768a to 1e6aceb Compare April 21, 2016 01:03

Add ocgis

1e6aceb

pelson merged commit a30262f into conda-forge:master Apr 21, 2016

jakirkham changed the title ~~WIP: ocgis~~ ocgis Apr 21, 2016

ocefpaf deleted the ocgis branch April 24, 2016 21:37

		@@ -0,0 +1,2 @@
		"%PYTHON%" setup.py install --single-version-externally-managed --record record.txt

ocgis #159

ocgis #159

Conversation

ocefpaf commented Mar 19, 2016 • edited Loading

pelson commented Mar 22, 2016

ocefpaf commented Mar 22, 2016

pelson commented Mar 22, 2016

conda-forge-admin commented Apr 1, 2016

conda-forge-admin commented Apr 2, 2016

pelson commented Apr 2, 2016

conda-forge-admin commented Apr 2, 2016

ocefpaf commented Apr 2, 2016

pelson commented Apr 2, 2016

ocefpaf commented Apr 6, 2016

bekozi commented Apr 6, 2016

ocefpaf commented Apr 6, 2016

ocefpaf commented Apr 6, 2016

ocefpaf commented Apr 8, 2016

bekozi commented Apr 8, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bekozi commented Apr 12, 2016

bekozi commented Apr 12, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ocefpaf commented Apr 12, 2016

jakirkham commented Apr 12, 2016

bekozi commented Apr 12, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ocefpaf commented Apr 18, 2016

conda-forge-linter commented Apr 21, 2016

ocefpaf commented Apr 21, 2016

bekozi commented Apr 21, 2016

ocefpaf commented Apr 21, 2016

jakirkham commented Apr 21, 2016

bekozi commented Apr 21, 2016

jakirkham commented Apr 21, 2016

ocefpaf commented Apr 24, 2016

ocefpaf commented Mar 19, 2016 •

edited

Loading