Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nzAutofocus mapping on nzModal #4126

Closed
frejfrej opened this issue Sep 7, 2019 · 0 comments
Closed

nzAutofocus mapping on nzModal #4126

frejfrej opened this issue Sep 7, 2019 · 0 comments
Assignees
Labels

Comments

@frejfrej
Copy link

frejfrej commented Sep 7, 2019

What problem does this feature solve?

Ant.design modal supports an autofocus property to enable autofocusing the ok or cancel button. This property is not available as nzAutofocus on nzModal

What does the proposed API look like?

Create the nzAutofocus property on nzModal to map the autofocus property of Modal

@hsuanxyz hsuanxyz added the 👨‍🏭 Some one working on this A community member has started working on this label Jan 16, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Jan 19, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Feb 3, 2020
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this issue Apr 9, 2020
* refactor(module:modal): refactor the modal service

close NG-ZORRO#3652, close NG-ZORRO#4437, close NG-ZORRO#2749

* feat(module:modal): support autofocus

close NG-ZORRO#3423, close NG-ZORRO#4126

* refactor(module:modal): refactor the modal component

* chore: rename files

* test(module:modal): add test case

* test(module:modal): add test case

* feat(module:modal): support nzCloseOnNavigation

* feat(module:modal): support nzViewContainerRef

close NG-ZORRO#4710

test(module:modal): add footer directive test

test(module:modal): add callback test

test(module:modal): add animation test

test(module:modal): add classname and styles test

test(module:modal): add footer component test

test(module:modal): fix test

test(module:modal): fix test

test(module:modal): add confirm test

test(module:modal): fix test

test(module:modal): add component mode test

chore: remove console

test: fix ci test
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
* refactor(module:modal): refactor the modal service

close NG-ZORRO#3652, close NG-ZORRO#4437, close NG-ZORRO#2749

* feat(module:modal): support autofocus

close NG-ZORRO#3423, close NG-ZORRO#4126

* refactor(module:modal): refactor the modal component

* chore: rename files

* test(module:modal): add test case

* test(module:modal): add test case

* feat(module:modal): support nzCloseOnNavigation

* feat(module:modal): support nzViewContainerRef

close NG-ZORRO#4710

test(module:modal): add footer directive test

test(module:modal): add callback test

test(module:modal): add animation test

test(module:modal): add classname and styles test

test(module:modal): add footer component test

test(module:modal): fix test

test(module:modal): fix test

test(module:modal): add confirm test

test(module:modal): fix test

test(module:modal): add component mode test

chore: remove console

test: fix ci test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants