refactor(module:modal): refactor the component #4702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4702 +/- ##
==========================================
- Coverage 93.37% 93.15% -0.23%
==========================================
Files 499 513 +14
Lines 12753 12939 +186
Branches 1965 1971 +6
==========================================
+ Hits 11908 12053 +145
- Misses 434 466 +32
- Partials 411 420 +9
Continue to review full report at Codecov.
|
|
This preview will be available after the AzureCI is passed. |
hsuanxyz
force-pushed
the
refactor/modal
branch
2 times, most recently
from
1f5e9a0
to
4f63fd0
Compare
close NG-ZORRO#3652, close NG-ZORRO#4437, close NG-ZORRO#2749
hsuanxyz
force-pushed
the
refactor/modal
branch
from
4103703
to
42bda02
Compare
close NG-ZORRO#4710 test(module:modal): add footer directive test test(module:modal): add callback test test(module:modal): add animation test test(module:modal): add classname and styles test test(module:modal): add footer component test test(module:modal): fix test test(module:modal): fix test test(module:modal): add confirm test test(module:modal): fix test test(module:modal): add component mode test chore: remove console test: fix ci test
hsuanxyz
force-pushed
the
refactor/modal
branch
from
b445369
to
8c705a2
Compare
This was referenced Mar 31, 2020
Ricbet
pushed a commit
to Ricbet/ng-zorro-antd
that referenced
this pull request
Apr 9, 2020
* refactor(module:modal): refactor the modal service close NG-ZORRO#3652, close NG-ZORRO#4437, close NG-ZORRO#2749 * feat(module:modal): support autofocus close NG-ZORRO#3423, close NG-ZORRO#4126 * refactor(module:modal): refactor the modal component * chore: rename files * test(module:modal): add test case * test(module:modal): add test case * feat(module:modal): support nzCloseOnNavigation * feat(module:modal): support nzViewContainerRef close NG-ZORRO#4710 test(module:modal): add footer directive test test(module:modal): add callback test test(module:modal): add animation test test(module:modal): add classname and styles test test(module:modal): add footer component test test(module:modal): fix test test(module:modal): fix test test(module:modal): add confirm test test(module:modal): fix test test(module:modal): add component mode test chore: remove console test: fix ci test
hsuanxyz
added a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
* refactor(module:modal): refactor the modal service close NG-ZORRO#3652, close NG-ZORRO#4437, close NG-ZORRO#2749 * feat(module:modal): support autofocus close NG-ZORRO#3423, close NG-ZORRO#4126 * refactor(module:modal): refactor the modal component * chore: rename files * test(module:modal): add test case * test(module:modal): add test case * feat(module:modal): support nzCloseOnNavigation * feat(module:modal): support nzViewContainerRef close NG-ZORRO#4710 test(module:modal): add footer directive test test(module:modal): add callback test test(module:modal): add animation test test(module:modal): add classname and styles test test(module:modal): add footer component test test(module:modal): fix test test(module:modal): fix test test(module:modal): add confirm test test(module:modal): fix test test(module:modal): add component mode test chore: remove console test: fix ci test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information