Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:i18n): update date-fns to 2.x #4240

Closed
wants to merge 5 commits into from

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Sep 29, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[x] Other... Please describe: update a core dependency (date-fns) to 2.x

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Breaking changes will be introduced by date-fns, see https://github.com/date-fns/date-fns/blob/master/CHANGELOG.md#changed.

Other information

@wzhudev wzhudev added 💔 Breaking Change This PR or the solution to this issue would introduce breaking changes PR: target-major labels Sep 29, 2019
@netlify
Copy link

netlify bot commented Sep 29, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 06c8028

https://deploy-preview-4240--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Oct 5, 2019

Codecov Report

Merging #4240 into master will increase coverage by 0.11%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4240      +/-   ##
==========================================
+ Coverage    92.2%   92.31%   +0.11%     
==========================================
  Files         520      519       -1     
  Lines       11039    10963      -76     
  Branches     1997     1984      -13     
==========================================
- Hits        10178    10121      -57     
+ Misses        429      419      -10     
+ Partials      432      423       -9
Impacted Files Coverage Δ
components/core/time/candy-date.ts 85.26% <ø> (ø) ⬆️
components/comment/demo/list.ts 100% <ø> (ø) ⬆️
components/comment/demo/editor.ts 100% <ø> (ø) ⬆️
components/comment/demo/basic.ts 100% <100%> (ø) ⬆️
components/i18n/date-helper.service.ts 72% <60%> (+4%) ⬆️
...otification/nz-notification-container.component.ts 92.59% <0%> (-3.71%) ⬇️
...mponents/message/nz-message-container.component.ts 87.87% <0%> (-3.04%) ⬇️
components/menu/nz-menu-item.directive.ts 76.71% <0%> (-2.74%) ⬇️
...mponents/tooltip/base/nz-tooltip-base.directive.ts 90.81% <0%> (-0.28%) ⬇️
components/button/nz-button.component.ts 94.11% <0%> (-0.25%) ⬇️
... and 75 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13b861c...9fa6423. Read the comment docs.

@wenqi73
Copy link
Member

wenqi73 commented Oct 25, 2019

这个 PR 合到了 #4346

@wzhudev
Copy link
Member Author

wzhudev commented Oct 25, 2019

@wenqi73 这个会带来 break change,最好不要在一个 PR 里做,如果用户传了格式化字符串会挂掉的

@wenqi73
Copy link
Member

wenqi73 commented Oct 25, 2019

@wendzhue 会放到 9.0.0 再合。

@wzhudev
Copy link
Member Author

wzhudev commented Oct 25, 2019

@wenqi73 那这个 PR 我先关了

@wzhudev wzhudev closed this Oct 25, 2019
@wzhudev wzhudev deleted the update-date-fns branch November 7, 2019 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💔 Breaking Change This PR or the solution to this issue would introduce breaking changes PR: target-major PR: unreviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants