feat(module:date-picker): support parsing input value #4346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Deploy preview for ng-zorro-master ready! Built with commit 512c85f |
wenqi73
changed the title
wzhudev
added
PR: target-major
💔 Breaking Change
Codecov Report
@@ Coverage Diff @@
## master #4346 +/- ##
=========================================
+ Coverage 93.21% 93.31% +0.1%
=========================================
Files 521 521
Lines 12814 12815 +1
Branches 2018 2011 -7
=========================================
+ Hits 11944 11958 +14
+ Misses 454 450 -4
+ Partials 416 407 -9
Continue to review full report at Codecov.
|
wenqi73
changed the title
wenqi73
force-pushed
the
date-fns2.x
branch
5 times, most recently
from
5966f4c
to
512c85f
Compare
wenqi73
changed the title
|
@wenqi73 Any updates on this PR? we're waiting for the release of these changes. |
|
@daxilsshah We are evaluating the breaking changes this feature and will give some feedback here. |
wzhudev
reviewed
Nov 22, 2019
| this.cdr.markForCheck(); | ||
| } | ||
|
|
||
| protected setFormat(): void {} |
There was a problem hiding this comment.
用了 implements 后就不能用 abstract 了。
| @@ -21,6 +21,6 @@ import { Component } from '@angular/core'; | |||
| ] | |||
| }) | |||
| export class NzDemoDatePickerFormatComponent { | |||
| dateFormat = 'yyyy/MM/dd'; | |||
| monthFormat = 'yyyy/MM'; | |||
| dateFormat = 'dd.MM.yyyy'; | |||
|
Hello, what about this fix, do you need help? And is-it possible to add a mask on the input ? thanks a lot |
chore: use parseDate fn in datehelper
wenqi73
changed the title
|
Very interested in this PR. |
|
See #4833 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #4028
Close #3976
Close #2492
Close #4101
默认的日期格式使用国际化文件中的dateFormat属性对应的值。新功能
date-fns 1.x 不支持日期的反格式化，相关 issue 有：#4028 #3976 #2492 #4101。
date-fnx 2.x 已支持该功能。
如何实现
由于 angular 的日期格式与 date-fns 的日期格式并不兼容。因此反格式化功能只有在用户引入了 date-fns 才能使用。
Breaking Change
Changelog: https://github.com/date-fns/date-fns/blob/master/CHANGELOG.md#200---2019-08-20
我们建议用户同步 NG-ZORRO 升级到 2.x 版本。
PR Checklist
Please check if your PR fulfills the requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
API has changed, please merge in 9.0.0.