Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:core): outside click closed the lower overlay #6064

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hsuanxyz
Copy link
Member

close #6060

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Nov 18, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Nov 18, 2020

Codecov Report

Merging #6064 (70c5f48) into master (3204927) will increase coverage by 0.01%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6064      +/-   ##
==========================================
+ Coverage   89.89%   89.90%   +0.01%     
==========================================
  Files         465      466       +1     
  Lines       14057    14063       +6     
  Branches     2311     2310       -1     
==========================================
+ Hits        12636    12644       +8     
  Misses        873      873              
+ Partials      548      546       -2     
Impacted Files Coverage Δ
components/core/overlay/nz-overlay.module.ts 100.00% <ø> (ø)
components/date-picker/picker.component.ts 89.47% <ø> (ø)
components/popconfirm/popconfirm.ts 100.00% <ø> (ø)
components/popover/popover.ts 92.85% <ø> (ø)
components/select/select.component.ts 88.25% <ø> (+0.54%) ⬆️
components/time-picker/time-picker.component.ts 87.20% <ø> (+1.26%) ⬆️
components/tooltip/base.ts 91.28% <ø> (-0.14%) ⬇️
components/tooltip/tooltip.ts 100.00% <ø> (ø)
components/tree-select/tree-select.component.ts 93.46% <ø> (-0.10%) ⬇️
components/mention/mention.component.ts 97.61% <50.00%> (-0.57%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3204927...70c5f48. Read the comment docs.

@hsuanxyz hsuanxyz force-pushed the fix/click-outside branch 2 times, most recently from b5d3392 to 1e9efcc Compare November 18, 2020 08:58
@wzhudev
Copy link
Member

wzhudev commented Jun 22, 2021

https://zhuanlan.zhihu.com/p/364776062 Will this be helpful?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popover disappeared when mouse click after modal shows
2 participants