Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:core): outside click closed the lower overlay #6064

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion components/auto-complete/autocomplete-trigger.directive.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
FlexibleConnectedPositionStrategy,
Overlay,
OverlayConfig,
OverlayContainer,
OverlayRef,
PositionStrategy
} from '@angular/cdk/overlay';
Expand Down Expand Up @@ -79,6 +80,7 @@ export class NzAutocompleteTriggerDirective implements ControlValueAccessor, OnD
constructor(
private elementRef: ElementRef,
private overlay: Overlay,
private overlayContainer: OverlayContainer,
private viewContainerRef: ViewContainerRef,
@Optional() private nzInputGroupWhitSuffixOrPrefixDirective: NzInputGroupWhitSuffixOrPrefixDirective,
@Optional() @Inject(DOCUMENT) private document: NzSafeAny
Expand Down Expand Up @@ -216,7 +218,13 @@ export class NzAutocompleteTriggerDirective implements ControlValueAccessor, OnD

private subscribeOverlayOutsideClick(): Subscription {
return this.overlayRef!.outsidePointerEvents()
.pipe(filter((e: MouseEvent) => !this.elementRef.nativeElement.contains(e.target)))
.pipe(
filter(
(e: MouseEvent) =>
!this.elementRef.nativeElement.contains(e.target) &&
!this.overlayContainer.getContainerElement().contains(e.target as HTMLElement)
)
)
.subscribe(() => {
this.closePanel();
});
Expand Down
1 change: 1 addition & 0 deletions components/cascader/cascader.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,7 @@ describe('cascader', () => {
fixture.detectChanges();
tick(200);
fixture.detectChanges();
console.log(testComponent.cascader.menuVisible);
expect(testComponent.cascader.menuVisible).toBe(true);
expect(testComponent.onVisibleChange).toHaveBeenCalledTimes(1);

Expand Down
37 changes: 37 additions & 0 deletions components/core/overlay/nz-outsite-click.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
/**
* Use of this source code is governed by an MIT-style license that can be
* found in the LICENSE file at https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/LICENSE
*/

import { CdkConnectedOverlay, OverlayContainer } from '@angular/cdk/overlay';
import { Directive, EventEmitter, Input, OnDestroy, OnInit, Output } from '@angular/core';
import { BooleanInput } from 'ng-zorro-antd/core/types';
import { InputBoolean } from 'ng-zorro-antd/core/util';
import { Subscription } from 'rxjs';

@Directive({
selector: '[cdkConnectedOverlay][nzOutsideClick]',
exportAs: 'nzOutsideClick'
})
export class NzOutsideClickDirective implements OnDestroy, OnInit {
static ngAcceptInputType_nzIgnoreOriginWthOutsideClick: BooleanInput;

@Output() readonly nzOutsideClick = new EventEmitter<MouseEvent>();
@Input() @InputBoolean() nzIgnoreOriginWthOutsideClick = false;
private backdropClickSubscription = Subscription.EMPTY;
constructor(private cdkConnectedOverlay: CdkConnectedOverlay, private overlayContainer: OverlayContainer) {}

ngOnInit(): void {
this.backdropClickSubscription = this.cdkConnectedOverlay.overlayOutsideClick.asObservable().subscribe((event: MouseEvent) => {
const inContainer = this.overlayContainer.getContainerElement().contains(event.target as HTMLElement);
const inOrigin = this.cdkConnectedOverlay.origin.elementRef.nativeElement.contains(event.target as HTMLElement);
if (!inContainer && (!this.nzIgnoreOriginWthOutsideClick || !inOrigin)) {
this.nzOutsideClick.emit(event);
}
});
}

ngOnDestroy(): void {
this.backdropClickSubscription.unsubscribe();
}
}
5 changes: 3 additions & 2 deletions components/core/overlay/nz-overlay.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,10 @@

import { NgModule } from '@angular/core';
import { NzConnectedOverlayDirective } from './nz-connected-overlay';
import { NzOutsideClickDirective } from './nz-outsite-click';

@NgModule({
declarations: [NzConnectedOverlayDirective],
exports: [NzConnectedOverlayDirective]
declarations: [NzConnectedOverlayDirective, NzOutsideClickDirective],
exports: [NzConnectedOverlayDirective, NzOutsideClickDirective]
})
export class NzOverlayModule {}
1 change: 1 addition & 0 deletions components/core/overlay/public-api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,6 @@
*/

export * from './nz-connected-overlay';
export * from './nz-outsite-click';
export * from './nz-overlay.module';
export * from './overlay-position';
2 changes: 1 addition & 1 deletion components/date-picker/picker.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ import { PREFIX_CLASS } from './util';
(positionChange)="onPositionChange($event)"
(detach)="onOverlayDetach()"
(overlayKeydown)="onOverlayKeydown($event)"
(overlayOutsideClick)="onClickOutside($event)"
(nzOutsideClick)="onClickOutside($event)"
>
<div class="ant-picker-wrapper" [nzNoAnimation]="noAnimation" [@slideMotion]="'enter'" style="position: relative;">
<div
Expand Down
6 changes: 5 additions & 1 deletion components/mention/mention.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
FlexibleConnectedPositionStrategy,
Overlay,
OverlayConfig,
OverlayContainer,
OverlayRef,
PositionStrategy
} from '@angular/cdk/overlay';
Expand Down Expand Up @@ -129,6 +130,7 @@ export class NzMentionComponent implements OnDestroy, OnInit, OnChanges {
@Optional() @Inject(DOCUMENT) private ngDocument: NzSafeAny,
private cdr: ChangeDetectorRef,
private overlay: Overlay,
private overlayContainer: OverlayContainer,
private viewContainerRef: ViewContainerRef,
private nzMentionService: NzMentionService
) {}
Expand Down Expand Up @@ -329,7 +331,9 @@ export class NzMentionComponent implements OnDestroy, OnInit, OnChanges {
fromEvent<TouchEvent>(this.ngDocument, 'touchend')
).subscribe((event: MouseEvent | TouchEvent) => {
const clickTarget = event.target as HTMLElement;
if (this.isOpen && clickTarget !== this.trigger.el.nativeElement && !this.overlayRef?.overlayElement.contains(clickTarget)) {
const inOverlayContainer = this.overlayContainer.getContainerElement().contains(clickTarget);
const inOverlayElement = this.overlayRef?.overlayElement.contains(clickTarget);
if (this.isOpen && clickTarget !== this.trigger.el.nativeElement && !inOverlayContainer && !inOverlayElement) {
this.closeDropdown();
}
});
Expand Down
3 changes: 2 additions & 1 deletion components/popconfirm/popconfirm.ts
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,9 @@ export class NzPopconfirmDirective extends NzTooltipBaseDirective {
#overlay="cdkConnectedOverlay"
cdkConnectedOverlay
nzConnectedOverlay
nzIgnoreOriginWthOutsideClick
[cdkConnectedOverlayOrigin]="origin"
(overlayOutsideClick)="onClickOutside($event)"
(nzOutsideClick)="hide()"
(detach)="hide()"
(positionChange)="onPositionChange($event)"
[cdkConnectedOverlayPositions]="_positions"
Expand Down
2 changes: 1 addition & 1 deletion components/popover/demo/module
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { NzPopoverModule } from 'ng-zorro-antd/popover';
import { NzButtonModule } from 'ng-zorro-antd/button';
import { NzIconModule } from 'ng-zorro-antd/icon';
import { NzPopoverModule } from 'ng-zorro-antd/popover';

export const moduleList = [ NzPopoverModule, NzButtonModule, NzIconModule ];
3 changes: 2 additions & 1 deletion components/popover/popover.ts
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,12 @@ export class NzPopoverDirective extends NzTooltipBaseDirective {
#overlay="cdkConnectedOverlay"
cdkConnectedOverlay
nzConnectedOverlay
nzIgnoreOriginWthOutsideClick
[cdkConnectedOverlayOrigin]="origin"
[cdkConnectedOverlayPositions]="_positions"
[cdkConnectedOverlayOpen]="_visible"
[cdkConnectedOverlayPush]="true"
(overlayOutsideClick)="onClickOutside($event)"
(nzOutsideClick)="hide()"
(detach)="hide()"
(positionChange)="onPositionChange($event)"
>
Expand Down
9 changes: 2 additions & 7 deletions components/select/select.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -107,14 +107,15 @@ export type NzSelectSizeType = 'large' | 'default' | 'small';
<ng-template
cdkConnectedOverlay
nzConnectedOverlay
nzIgnoreOriginWthOutsideClick
[cdkConnectedOverlayMinWidth]="$any(nzDropdownMatchSelectWidth ? null : triggerWidth)"
[cdkConnectedOverlayWidth]="$any(nzDropdownMatchSelectWidth ? triggerWidth : null)"
[cdkConnectedOverlayOrigin]="origin"
[cdkConnectedOverlayTransformOriginOn]="'.ant-select-dropdown'"
[cdkConnectedOverlayPanelClass]="nzDropdownClassName!"
[cdkConnectedOverlayOpen]="nzOpen"
(overlayKeydown)="onOverlayKeyDown($event)"
(overlayOutsideClick)="onClickOutside($event)"
(nzOutsideClick)="setOpenState(false)"
(detach)="setOpenState(false)"
(positionChange)="onPositionChange($event)"
>
Expand Down Expand Up @@ -461,12 +462,6 @@ export class NzSelectComponent implements ControlValueAccessor, OnInit, AfterVie
this.updateListOfValue([]);
}

onClickOutside(event: MouseEvent): void {
if (!this.elementRef.nativeElement.contains(event.target)) {
this.setOpenState(false);
}
}

focus(): void {
this.nzSelectTopControlComponent.focus();
}
Expand Down
9 changes: 2 additions & 7 deletions components/time-picker/time-picker.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,14 @@ const NZ_CONFIG_MODULE_NAME: NzConfigKey = 'timePicker';
<ng-template
cdkConnectedOverlay
nzConnectedOverlay
nzIgnoreOriginWthOutsideClick
[cdkConnectedOverlayPositions]="overlayPositions"
[cdkConnectedOverlayOrigin]="origin"
[cdkConnectedOverlayOpen]="nzOpen"
[cdkConnectedOverlayOffsetY]="-2"
[cdkConnectedOverlayTransformOriginOn]="'.ant-picker-dropdown'"
(detach)="close()"
(overlayOutsideClick)="onClickOutside($event)"
(nzOutsideClick)="setCurrentValueAndClose()"
>
<div [@slideMotion]="'enter'" class="ant-picker-dropdown">
<div class="ant-picker-panel-container">
Expand Down Expand Up @@ -218,12 +219,6 @@ export class NzTimePickerComponent implements ControlValueAccessor, OnInit, Afte
this.emitValue(null);
}

onClickOutside(event: MouseEvent): void {
if (!this.element.nativeElement.contains(event.target)) {
this.setCurrentValueAndClose();
}
}

onFocus(value: boolean): void {
this.focused = value;
}
Expand Down
6 changes: 0 additions & 6 deletions components/tooltip/base.ts
Original file line number Diff line number Diff line change
Expand Up @@ -421,12 +421,6 @@ export abstract class NzTooltipBaseComponent implements OnDestroy {
this.cdr.markForCheck();
}

onClickOutside(event: MouseEvent): void {
if (!this.origin.elementRef.nativeElement.contains(event.target)) {
this.hide();
}
}

/**
* Hide the component while the content is empty.
*/
Expand Down
3 changes: 2 additions & 1 deletion components/tooltip/tooltip.ts
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,12 @@ export class NzTooltipDirective extends NzTooltipBaseDirective {
#overlay="cdkConnectedOverlay"
cdkConnectedOverlay
nzConnectedOverlay
nzIgnoreOriginWthOutsideClick
[cdkConnectedOverlayOrigin]="origin"
[cdkConnectedOverlayOpen]="_visible"
[cdkConnectedOverlayPositions]="_positions"
[cdkConnectedOverlayPush]="true"
(overlayOutsideClick)="onClickOutside($event)"
(nzOutsideClick)="hide()"
(detach)="hide()"
(positionChange)="onPositionChange($event)"
>
Expand Down
14 changes: 4 additions & 10 deletions components/tree-select/tree-select.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,13 @@ const TREE_SELECT_DEFAULT_CLASS = 'ant-select-dropdown ant-select-tree-dropdown'
<ng-template
cdkConnectedOverlay
nzConnectedOverlay
nzIgnoreOriginWthOutsideClick
[cdkConnectedOverlayOrigin]="cdkOverlayOrigin"
[cdkConnectedOverlayOpen]="nzOpen"
[cdkConnectedOverlayTransformOriginOn]="'.ant-select-tree-dropdown'"
[cdkConnectedOverlayMinWidth]="$any(nzDropdownMatchSelectWidth ? null : triggerWidth)"
[cdkConnectedOverlayWidth]="$any(nzDropdownMatchSelectWidth ? triggerWidth : null)"
(overlayOutsideClick)="onClickOutside($event)"
(nzOutsideClick)="closeDropDown()"
(detach)="closeDropDown()"
(positionChange)="onPositionChange($event)"
>
Expand Down Expand Up @@ -121,7 +122,7 @@ const TREE_SELECT_DEFAULT_CLASS = 'ant-select-dropdown ant-select-tree-dropdown'
</div>
</ng-template>

<div cdkOverlayOrigin class="ant-select-selector">
<div cdkOverlayOrigin class="ant-select-selector" (click)="trigger()">
<ng-container *ngIf="isMultiple">
<nz-select-item
*ngFor="let node of selectedNodes | slice: 0:nzMaxTagCount; trackBy: trackValue"
Expand Down Expand Up @@ -201,8 +202,7 @@ const TREE_SELECT_DEFAULT_CLASS = 'ant-select-dropdown ant-select-tree-dropdown'
'[class.ant-select-show-search]': '!isMultiple',
'[class.ant-select-multiple]': 'isMultiple',
'[class.ant-select-allow-clear]': 'nzAllowClear',
'[class.ant-select-open]': 'nzOpen',
'(click)': 'trigger()'
'[class.ant-select-open]': 'nzOpen'
}
})
export class NzTreeSelectComponent extends NzTreeBase implements ControlValueAccessor, OnInit, OnDestroy, OnChanges {
Expand Down Expand Up @@ -517,12 +517,6 @@ export class NzTreeSelectComponent extends NzTreeBase implements ControlValueAcc
this.nzCleared.emit();
}

onClickOutside(event: MouseEvent): void {
if (!this.elementRef.nativeElement.contains(event.target)) {
this.closeDropDown();
}
}

setSearchValues($event: NzFormatEmitEvent): void {
Promise.resolve().then(() => {
this.isNotFound = (this.nzShowSearch || this.isMultiple) && !!this.inputValue && $event.matchedKeys!.length === 0;
Expand Down
Loading