Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabled SymbolPackageFormat=snupkg #333

Merged
merged 1 commit into from
Jan 6, 2019
Merged

Enabled SymbolPackageFormat=snupkg #333

merged 1 commit into from
Jan 6, 2019

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Jan 5, 2019 •
edited
Loading

And removed dotnet-xunit as it has become obsolete.

@snakefoot
Copy link
Contributor Author

Successfully created package 'C:\projects\nlogweb\NLog.Web.AspNetCore\bin\Any CPU\release\NLog.Web.AspNetCore.4.7.0.snupkg'.

@codecov
Copy link

codecov bot commented Jan 5, 2019

Codecov Report

Merging #333 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #333   +/-   ##
=====================================
  Coverage      64%    64%           
=====================================
  Files          33     33           
  Lines         461    461           
  Branches      101    101           
=====================================
  Hits          296    296           
  Misses        127    127           
  Partials       38     38

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dec477e...ea5fd6b. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 5, 2019 •
edited
Loading

Codecov Report

Merging #333 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #333   +/-   ##
=====================================
  Coverage      64%    64%           
=====================================
  Files          33     33           
  Lines         461    461           
  Branches      101    101           
=====================================
  Hits          296    296           
  Misses        127    127           
  Partials       38     38

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dec477e...ea5fd6b. Read the comment docs.

@snakefoot snakefoot mentioned this pull request Jan 5, 2019
Merged
@304NotModified
Copy link
Member

thanks!!

@304NotModified 304NotModified merged commit 5caf12e into NLog:master Jan 6, 2019
@snakefoot snakefoot added ASP.NET 4 ASP.NET MVC Classic ASP.NET Core ASP.NET Core - all versions and removed ASP.NET Core 1 ASP.NET 4 ASP.NET MVC Classic labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ASP.NET Core ASP.NET Core - all versions build-config
Projects
None yet
Milestone
NLog.Web + NLog.Web.AspNetCore 4.7.1
Development

Successfully merging this pull request may close these issues.
2 participants
@snakefoot @304NotModified