Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled SymbolPackageFormat=snupkg #333

Merged
merged 1 commit into from
Jan 6, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions NLog.Web.AspNetCore.Tests/NLog.Web.AspNetCore.Tests.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,17 @@
<AssemblyVersion>1.2.3.0</AssemblyVersion>
<FileVersion>1.2.3.1</FileVersion>
<InformationalVersion>1.2.3.2</InformationalVersion>
<DebugType Condition=" '$(TargetFramework)' == 'net461' ">Full</DebugType>
</PropertyGroup>

<PropertyGroup Condition=" '$(TargetFramework)' == 'netcoreapp1.1' ">

<DefineConstants>$(DefineConstants);ASP_NET_CORE;ASP_NET_CORE1</DefineConstants>
</PropertyGroup>

<PropertyGroup Condition=" '$(TargetFramework)' != 'netcoreapp1.1' ">
<RuntimeFrameworkVersion>2.0.0</RuntimeFrameworkVersion>
<DefineConstants>$(DefineConstants);ASP_NET_CORE;ASP_NET_CORE2</DefineConstants>
</PropertyGroup>



<ItemGroup>
<ProjectReference Include="..\NLog.Web.AspNetCore\NLog.Web.AspNetCore.csproj" />
Expand All @@ -28,11 +27,8 @@
<PackageReference Include="xunit.runner.visualstudio" Version="2.3.1" />
<PackageReference Include="xunit" Version="2.3.1" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.5.0" />
<!--
icrosoft.NET.Test.Sdk needed for xunit.runner.visualstudio
-->
<DotNetCliToolReference Include="dotnet-xunit" Version="2.3.1" />
</ItemGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'netcoreapp1.1' ">
<PackageReference Include="Microsoft.AspNetCore" Version="1.1.1" />
</ItemGroup>
Expand Down
2 changes: 2 additions & 0 deletions NLog.Web.AspNetCore/NLog.Web.AspNetCore.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,13 @@ Supported platforms:
<Title>NLog.Web.AspNetCore for .NET Framework 4.5.1+</Title>
<DisableImplicitFrameworkReferences>true</DisableImplicitFrameworkReferences>
<DefineConstants>$(DefineConstants);ASP_NET_CORE;ASP_NET_CORE1</DefineConstants>
<DebugType Condition=" '$(Configuration)' == 'Debug' ">Full</DebugType>
</PropertyGroup>
<PropertyGroup Condition=" '$(TargetFramework)' == 'net461' ">
<Title>NLog.Web.AspNetCore for .NET Framework 4.6+</Title>
<DisableImplicitFrameworkReferences>true</DisableImplicitFrameworkReferences>
<DefineConstants>$(DefineConstants);ASP_NET_CORE;ASP_NET_CORE2</DefineConstants>
<DebugType Condition=" '$(Configuration)' == 'Debug' ">Full</DebugType>
</PropertyGroup>
<PropertyGroup Condition=" '$(TargetFramework)' == 'netstandard1.5' ">
<Title>NLog.Web.AspNetCore for NetStandard 1.5</Title>
Expand Down
1 change: 1 addition & 0 deletions appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,4 @@ test_script:

artifacts:
- path: '**\NLog.Web.*.nupkg'
- path: '**\NLog.Web.*.snupkg'
2 changes: 1 addition & 1 deletion build_aspnetcore.bat
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@ echo off
rem update NLog.Web.AspNetCore.csproj for version number

cd NLog.Web.AspNetCore
msbuild /t:restore /t:build /p:configuration=release /verbosity:minimal
msbuild /t:restore /t:build /p:configuration=release /verbosity:minimal /p:IncludeSymbols=true /p:SymbolPackageFormat=snupkg
cd ..
2 changes: 1 addition & 1 deletion test_aspnetcore.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ if (-Not $LastExitCode -eq 0) { exit $LastExitCode }
dotnet build --configuration release
if (-Not $LastExitCode -eq 0) { exit $LastExitCode }

dotnet xunit
dotnet test
if (-Not $LastExitCode -eq 0) { exit $LastExitCode }

set-location ..