Bugfix/trnc

[mickaelaccensi]

Pull Request Summary

correct calendar for track netcdf output

Description

read the mod_def.ww3 to define the calendar type
update output dates in regtest ww3_tp2.2 to show the issue

Issue(s) addressed

issue #1077

Commit Message

correct calendar for track netcdf output

Check list

• Branch is up to date with the authoritative repository (NOAA-EMC) develop branch.
• Checked the checklist for a developer submitting to develop.
• If a version number update is required, checked the updating version number checklist.
• If a new feature was added, a regression test for testing the new feature is added.

Testing

• How were these changes tested? ww3_tp2.2
• Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) ww3_tp2.2
• Have the matrix regression tests been run (if yes, please note HPC and compiler)? on going
• Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
• only changes in ww3_tp2.2 in the output dates
• Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

[MatthewMasarik-NOAA]

Thanks @mickaelaccensi. There's a few PR's ahead of this one, I've updated the commit queue.

[MatthewMasarik-NOAA]

Hi @mickaelaccensi I appreciate you documenting that ww3_tp2.2 will change.

Can you please also remember to attach the runs logs required in the PR header? We're trying to keep the review process moving as quickly as possible and filling out the PR header completely helps. In a broader sense we are going to review our PR template and how we're communicating the requirements, so just a general heads up there will be more to come on that shortly.

[MatthewMasarik-NOAA]

PRs #1073 and #1076 are still being tested, so this PR is up next. Thanks for syncing. I'll start testing, the timeline is beginning of next week. The commit queue is updated now.

[MatthewMasarik-NOAA]

matrix.comp

**********************************************************************          
********************* non-identical cases ****************************          
**********************************************************************          
## known non-b4b                                                                
mww3_test_03/./work_PR3_UNO_MPI_e                     (1 files differ)          
mww3_test_03/./work_PR2_UQ_MPI_e                     (1 files differ)           
mww3_test_03/./work_PR2_UNO_MPI_d2                     (16 files differ)        
mww3_test_03/./work_PR1_MPI_d2                     (8 files differ)             
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (10 files differ)      
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (15 files differ)       
mww3_test_03/./work_PR3_UNO_MPI_d2                     (18 files differ)        
mww3_test_03/./work_PR2_UQ_MPI_d2                     (15 files differ)         
mww3_test_03/./work_PR3_UQ_MPI_e                     (1 files differ)           
mww3_test_03/./work_PR3_UQ_MPI_d2                     (17 files differ)         
ww3_tp2.10/./work_MPI_OMPH                     (7 files differ)                 
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)                 
ww3_ufs1.3/./work_a                     (3 files differ)                        
##                                                                              
                                                                                
ww3_tp2.2/./work_PR2_UNO                     (14 files differ)                  
ww3_tp2.2/./work_PR1_MPI                     (14 files differ)                  
ww3_tp2.2/./work_PR3_UNO_MPI                 (14 files differ)              
ww3_tp2.2/./work_PR3_UQ                      (14 files differ)                   
ww3_tp2.2/./work_PR3_UNO                     (14 files differ)                  
ww3_tp2.2/./work_PR1                         (14 files differ)                      
ww3_tp2.2/./work_PR2_UQ                      (14 files differ)                   
ww3_tp2.2/./work_PR2_UQ_MPI                  (14 files differ)               
ww3_tp2.2/./work_PR3_UQ_MPI                  (14 files differ)               
ww3_tp2.2/./work_PR2_UNO_MPI                 (14 files differ)                                                              
**********************************************************************          
************************ identical cases *****************************          
**********************************************************************

ww3_tp2.2 diffs

The 14 files differing for each of the tests above are listed here, plus 4 *.nc files at the bottom not compared due to differing file names from this change. All diffs in the files were seen to be due to shift in date from 1968-06 to 2022-06:

     log.ww3                            
     out_grd.ww3               
     out_pnt.ww3                
     tab51.ww3
     tab52.ww3
     tab53.ww3
     track_o.ww3
     ww3_ounf.out
     ww3_ounp.out
     ww3_outf.out
     ww3_outp_spec.out
     ww3_outp_tab51.out
     ww3_outp_tab52.out
     ww3_outp_tab53.out
 
     ww3.196806.nc        -- not in compare directory        
     ww3.196806_spec.nc   -- not in compare directory           
     ww3.202206.nc        -- in comp directory only          
     ww3.202206_spec.nc   -- in comp directory only

All changes outside the known list of non-b4b tests have been accounted for.

Code review

PASS

Testing

PASS

Approved.

[MatthewMasarik-NOAA]

@mickaelaccensi thank you for finding this bug and submitting the fix.