Re-base with NOAA-EMC and fix gustiness #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ange UST scale factor (NOAA-EMC#1050)
…ile instead of inp file (NOAA-EMC#1070)
…n binary and ascii format using switch ASCII. (NOAA-EMC#1089)
…efined in w3odatmd (size=15). Also, defined unit numbers for NDS(14) and NDS(15). (NOAA-EMC#1098)
… DIA in NL1 or NL2. (NOAA-EMC#1083)
…ST4 code (NOAA-EMC#1124) Co-authored-by: Fabrice Ardhuin <[email protected]>
Co-authored-by: Denise Worthen <[email protected]>
…ompiled with the OMPG switch. Also fixes truncation of build.log when running run_cmake_build. (NOAA-EMC#1191) * Added screen output showing number of threads when OMP enabled. * update build to get more info in logs (NOAA-EMC#46) --------- Co-authored-by: Jessica Meixner <[email protected]>
…ge-noaa-develop-2
| @@ -672,7 +684,7 @@ SUBROUTINE W3SIN4 (A, CG, K, U, USTAR, DRAT, AS, USDIR, Z0, CD, & | |||
| ELSE | |||
| Usigma = MAX(0.,-0.025*AS) | |||
| END IF | |||
| USTARsigma=(1.0+U/(10.+U))*Usigma | |||
| USTARsigma=(0.895+U**(1.48)/(34.8+1.35*U**(1.48)))*Usigma | |||
There was a problem hiding this comment.
@camilleanne this is the only line I changed. The rest is the merge to NOAA-EMC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
This PR merges the latest changes in NOAA-EMC/WW3 to our own fork. It also fixes a bug in the gustiness parameterization (ST4 + STAB3)
Description
Updated to the WW3 source code, mostly related to wave dissipation parameterizations due to mud and ice. Some functionality has been added, like the ability to output text/ascii files instead of binary for easy plotting. There are some changes to some output generating files, but tests of WW3 simulations in ESM, which use the same pre-processing as in production do not show any failure or differences.
The bug fix for the gustiness parameterization is the only change that has an impact on the output of the simulation, generally improving the skill (in terms of bias and RMSD) of globally averaged SWH. This is done by implementing this schemes as in WAM.
Issue(s) addressed
No posted issues are solved, but it does provide an important fix to gustiness.
Commit Message
Merge/re-base to NOAA-EMC source code and fix to gustiness parameterization.
Authors: @miguelsolanocordoba and @camilleanne.
Check list
Testing
See ESM WW3 update in Notion doc