NCAR-main PR#956 #623
Merged
NCAR-main PR#956 #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 8, 2023 11:28
37 tasks
DusanJovic-NOAA
approved these changes
Feb 27, 2023
added 2 commits
February 27, 2023 13:01
|
@dustinswales ufs-community/ccpp-physics#38 has been merged. Please revert .gitmodules and update the ccpp-physics submodule pointer. |
ChunxiZhang-NOAA
approved these changes
Mar 2, 2023
|
@dustinswales correct ccpp hash is ufs-community/ccpp-physics@4a75606 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains new interstitial variables in GFS_typedefs to accommodate changes in the underlying physics. These changes are mostly related to the removal of a radiation configuration(data) module, physparam.f. Runtime information is set in GFS_typedefs and provided through the ccpp infrastructure, instead of referencing physparam.f throughout the physics.
Issue(s) addressed
Detailed in NCAR #956
Testing
Tested on Cheyenne and Hera with Intel.
Updates need for the RRTMGP RTs (see conversation in NCAR/ccpp-physics#956)