Set finer-grain workflow permissions #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @diogoteles08, finally got around to addressing this. Would you mind taking a look? |
|
I think we'll need to update https://github.com/NVIDIA/cccl/blob/main/.github/workflows/triage_rotation.yml as well. I think it just needs |
ajschmidt8
approved these changes
Nov 29, 2023
wmaxey
pushed a commit
that referenced
this pull request
Dec 1, 2023
* Set workflow read permissions and per-job write permissions. * set pull-requests read at workflow level. * Set contents read at job level. * Explicitly set job-level read permissions. * Add permissions to verify-devcontainers.
wmaxey
added a commit
that referenced
this pull request
Dec 1, 2023
* Avoid batch benchmarks * Relax minimal benchmarking time * Don't benchmark small problem sizes * Reduce sort workloads * Split benchmarks into shards * Fewer histogram benchmarks * Fewer seg sort benchmarks * Think about P0 algorithms * Extra print * Next round of simplification * Do not treat segmented problems as P0 * Fewer workloads for memcpy * Better workload filter * Do not stop on first bench failure * Update nvbench * Remove draft automation + reduce permissions (#1154) * Set finer-grain workflow permissions (#1163) * Set workflow read permissions and per-job write permissions. * set pull-requests read at workflow level. * Set contents read at job level. * Explicitly set job-level read permissions. * Add permissions to verify-devcontainers. --------- Co-authored-by: Georgy Evtushenko <[email protected]> Co-authored-by: Ben Jarmak <[email protected]> Co-authored-by: Jake Hemstad <[email protected]>
Hey @jrhemstad! Took a look and it looks good! Thanks for addressing this =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #919
In following with better security best practices, we don't want to rely on the default
GHA_TOKENpermissions.Instead, we want to set the least permissive permissions at the workflow level, and then set higher permissions at individual jobs that need them.
Most jobs need
id-token: writefor https://github.com/aws-actions/configure-aws-credentials for sccache configuration.