Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip-tests] Use builtin for destructible concept on MSVC #333

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

miscco
Copy link
Collaborator

@miscco miscco commented Aug 15, 2023

MSVC has issues with private destructors, so just use the builtin it provides.

C:\Users\swqa\Desktop\p4root\rel\gpgpu\toolkit\r12.3\cccl\libcudacxx\include\cuda\std\detail\libcxx\include\__concepts\../__concepts/destructible.h(37): error C2248: 'AbstractDestructor::~AbstractDestructor': cannot access private member declared in class 'AbstractDestructor'

This addresses nvbug200707001

@miscco miscco requested review from a team as code owners August 15, 2023 10:13
@miscco miscco requested review from wmaxey and griwes and removed request for a team August 15, 2023 10:13
@miscco
Copy link
Collaborator Author

miscco commented Aug 15, 2023

I verified manually that the builtin is available in 2017

C:\src\cccl\libcudacxx\build>lit test/std/concepts -sv
lit: C:\src\cccl\libcudacxx\test\lit.cfg:45: note: Using configuration variant: libcudacxx
lit: C:\src\cccl\libcudacxx\utils\libcudacxx\test\config.py:364: note: inferred use_system_cxx_lib as: None
lit: C:\src\cccl\libcudacxx\utils\libcudacxx\test\config.py:249: note: detected cxx.type as: nvcc
lit: C:\src\cccl\libcudacxx\utils\libcudacxx\test\config.py:251: note: detected cxx.version as: (12, 2, 91)
lit: C:\src\cccl\libcudacxx\utils\libcudacxx\test\config.py:253: note: detected cxx.default_dialect as: c++14
lit: C:\src\cccl\libcudacxx\utils\libcudacxx\test\config.py:255: note: detected cxx.is_nvrtc as: False
lit: C:\src\cccl\libcudacxx\utils\libcudacxx\test\config.py:283: note: detected host_cxx.type as: msvc
lit: C:\src\cccl\libcudacxx\utils\libcudacxx\test\config.py:285: note: detected host_cxx.version as: (19, 16, 27050)
lit: C:\src\cccl\libcudacxx\utils\libcudacxx\test\config.py:287: note: detected host_cxx.default_dialect as: c++14
lit: C:\src\cccl\libcudacxx\utils\libcudacxx\test\config.py:289: note: detected host_cxx.is_nvrtc as: False
lit: C:\src\cccl\libcudacxx\utils\libcudacxx\test\config.py:391: note: inferred use_clang_verify as: False
lit: C:\src\cccl\libcudacxx\utils\libcudacxx\test\config.py:667: note: inferred language dialect as: c++17
lit: C:\src\cccl\libcudacxx\utils\libcudacxx\test\target_info.py:67: warning: The locale Czech_Czech Republic.1250 is not supported by your platform. Some tests will be unsupported.
lit: C:\src\cccl\libcudacxx\utils\libcudacxx\test\config.py:484: note: inferred long_tests as: True
lit: C:\src\cccl\libcudacxx\utils\libcudacxx\test\config.py:160: note: Using compiler: C:/Program Files/NVIDIA GPU Computing Toolkit/CUDA/v12.2/bin/nvcc.exe
lit: C:\src\cccl\libcudacxx\utils\libcudacxx\test\config.py:161: note: Using flags: ['-v', '-ftemplate-depth=270']
lit: C:\src\cccl\libcudacxx\utils\libcudacxx\test\config.py:165: note: Using compile flags: ['-std=c++17', '-IC:/src/cccl/libcudacxx\\include', '-Xcompiler', '/GR-', '-D_SILENCE_CXX20_CISO646_REMOVED_WARNING', '-D_LIBCUDACXX_NO_RTTI', '-IC:/src/cccl/libcudacxx\\test/support', '-D_CRT_SECURE_NO_WARNINGS', '-DNOMINMAX', '-Xcompiler', '/bigobj', '-include', 'C:/src/cccl/libcudacxx/test/force_include.h', '-IC:/src/cccl/libcudacxx/include', '--extended-lambda']
lit: C:\src\cccl\libcudacxx\utils\libcudacxx\test\config.py:168: note: Using warnings: ['-Xcudafe', '--display_error_number', '-Werror=all-warnings', '-Xcompiler', '/W4', '-Xcompiler', '/WX', '-Xcompiler', '-wd4100', '-Xcompiler', '-wd4127', '-Xcompiler', '-wd4180', '-Xcompiler', '-wd4309', '-Xcompiler', '-wd4996']
lit: C:\src\cccl\libcudacxx\utils\libcudacxx\test\config.py:169: note: Using link flags: ['-lmsvcrt']
lit: C:\src\cccl\libcudacxx\utils\libcudacxx\test\config.py:171: note: Using available_features: ['msvc-19', 'LIBCUDACXX-WINDOWS-FIXME', 'pre-sm-70', 'c++filesystem-disabled', 'libcpp-no-exceptions', 'locale.ru_RU.UTF-8', 'pre-sm-32', 'locale.fr_CA.ISO8859-1', 'windows', 'libcpp-no-rtti', 'libc++', 'nvcc', 'pre-sm-60', 'nvcc-12.2', 'win32', 'msvc', 'pre-sm-80', 'locale.zh_CN.UTF-8', 'locale.fr_FR.UTF-8', 'long_tests', 'nvcc-12', 'dylib-has-no-filesystem', 'c++17', 'no-aligned-allocation', 'msvc-19.16', 'pre-sm-90', 'nvcc-12.2.91', 'locale.en_US.UTF-8']
lit: C:\src\cccl\libcudacxx\utils\libcudacxx\test\config.py:177: note: Adding environment variables: {}
-- Testing: 35 tests, 16 workers --
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..

Testing Time: 75.25s
  Unsupported:  4
  Passed     : 31

@miscco miscco added nvbug Has an associated internal NVIDIA NVBug. libcu++ For all items related to libcu++ bug Something isn't working right. labels Aug 15, 2023
MSVC has issues with private destructors, so just use the builtin it provides.

This addresses nvbug200707001
@miscco miscco requested a review from a team as a code owner August 15, 2023 16:28
@miscco miscco changed the base branch from main to branch/2.2.x August 15, 2023 16:29
@wmaxey wmaxey merged commit d70a624 into NVIDIA:branch/2.2.x Aug 15, 2023
370 checks passed
miscco added a commit to miscco/cccl that referenced this pull request Aug 16, 2023
MSVC has issues with private destructors, so just use the builtin it provides.

This addresses nvbug200707001
miscco added a commit to miscco/cccl that referenced this pull request Aug 17, 2023
MSVC has issues with private destructors, so just use the builtin it provides.

This addresses nvbug200707001
miscco added a commit that referenced this pull request Aug 17, 2023
MSVC has issues with private destructors, so just use the builtin it provides.

This addresses nvbug200707001
alliepiper pushed a commit to alliepiper/cccl that referenced this pull request Aug 30, 2023
MSVC has issues with private destructors, so just use the builtin it provides.

This addresses nvbug200707001
@miscco miscco deleted the destructible_msvc branch June 17, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working right. libcu++ For all items related to libcu++ nvbug Has an associated internal NVIDIA NVBug.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants