Merge commits from 2.2 branch #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replace COMPILER_NVCC_BELOW version macro with CUDACC version macro * Fix CUDACC query in NV_DIAG_SUPPRESS macro * [skip-tests] Also use `__CUDACC__` for libcu++ tests --------- Co-authored-by: Michael Schellenberger Costa <[email protected]>
MSVC has issues with private destructors, so just use the builtin it provides. This addresses nvbug200707001
We renamed `TEST_COMPILER_C1XX` to `TEST_COMPILER_MSVC` because the former does not make sense and the latter is the convention we have for the internal macro However, an inflight PR did miss the macro rename Skipping tests as this is only libcudacxx test related
miscco
requested review from
robertmaynard,
alliepiper,
jarmak-nv,
ericniebler and
gevtushenko
and removed request for
a team
elstehle
approved these changes
Aug 17, 2023
gevtushenko
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in 4 commits from 2.2