Support batching for RANGE running window aggregations. Including on [databricks]
#9544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for `FIRST()` window functions, running in a ROWS context. This does not currently support ignore/include nulls. Signed-off-by: MithunR <[email protected]>
Plus, tests for partitioned/unpartitioned, and keep/ignore nulls.
Also removed unused import.
Signed-off-by: MithunR <[email protected]>
GpuAlias covers the isRangeFrame check.
Signed-off-by: MithunR <[email protected]>
|
Build |
revans2
reviewed
Oct 30, 2023
This reverts commit 22aaf7c. Best not combine the running window ROW/RANGE tests.
mythrocks
added
reliability
|
build |
Signed-off-by: MithunR <[email protected]>
|
Thanks for the review, @revans2. I'm adding a couple of similar new tests for the partitioned cases. |
Signed-off-by: MithunR <[email protected]>
mythrocks
changed the title
RANGE running window aggregationsRANGE running window aggregations
|
Build |
mythrocks
changed the title
RANGE running window aggregationsRANGE running window aggregations. Including on [databricks]
|
Build |
revans2
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #9489, but applies to more than
FIRST().GpuRunningWindowExechandles "running-window" aggregations, i.e.[UNBOUNDED PRECEDING, CURRENT ROW, as long as they areROWbased window specifications.But when the window spec isn't specified, the default is to use
RANGE BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW:This causes the window aggregation to be done with a single batch, with an increased likelihood of OOMs.
This commit adds batching support for
RANGEqueries by including the order-by column in batching. This allows the rows with the same values of partition-keys and order-by-keys to be processed as part of the same batch. This allows us to avoid crossing batches for fix-ups.