Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support batching for RANGE running window aggregations. Including on [databricks] #9544

Merged
merged 23 commits into from
Nov 2, 2023
Merged

Support batching for RANGE running window aggregations. Including on [databricks] #9544

merged 23 commits into from
Nov 2, 2023

Commits on Oct 18, 2023

  1. Batching support for ROW-based FIRST() window function 

    This commit adds support for `FIRST()` window functions, running in a ROWS
context.

This does not currently support ignore/include nulls.

Signed-off-by: MithunR <[email protected]>
    @mythrocks
    mythrocks committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    4ccf617 View commit details
    Browse the repository at this point in the history

  2. Support for ignoreNulls.

    @mythrocks
    mythrocks committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    7d5adc9 View commit details
    Browse the repository at this point in the history

  3. Fixed backing up previous from current batch. 

    Plus, tests for partitioned/unpartitioned, and keep/ignore nulls.
    @mythrocks
    mythrocks committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    28743c5 View commit details
    Browse the repository at this point in the history

  4. Reworded GpuNthValue Literal check with match.

    @mythrocks
    mythrocks committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    b39a4f3 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. Merge remote-tracking branch 'origin/branch-23.12' into batched-windo… 

    …w-first
    @mythrocks
    mythrocks committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    6987164 View commit details
    Browse the repository at this point in the history

  2. Fix package path.

    @mythrocks
    mythrocks committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    5cc1985 View commit details
    Browse the repository at this point in the history

  3. Code-style fix: Fixed line length. 

    Also removed unused import.
    @mythrocks
    mythrocks committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    5c6e85d View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. Moved First-specific logic out of GpuWindowExec. 

    Signed-off-by: MithunR <[email protected]>
    @mythrocks
    mythrocks committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    9373b7a View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2023

  1. Added test for nth_value.

    @mythrocks
    mythrocks committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    af49389 View commit details
    Browse the repository at this point in the history

  2. Explicit canFix() check.

    @mythrocks
    mythrocks committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    42ec892 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Merge remote-tracking branch 'origin/branch-23.12' into batched-windo… 

    …w-first
    @mythrocks
    mythrocks committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    11ec8db View commit details
    Browse the repository at this point in the history

  2. First swipe.

    @mythrocks
    mythrocks committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    0c27e15 View commit details
    Browse the repository at this point in the history

  3. Removed unnecessary TODO. 

    GpuAlias covers the isRangeFrame check.
    @mythrocks
    mythrocks committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    a14bb8e View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. Merge remote-tracking branch 'origin/branch-23.12' into batched-range… 

    …-window-first
    @mythrocks
    mythrocks committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    b98560d View commit details
    Browse the repository at this point in the history

  2. Fixed rebase error.

    @mythrocks
    mythrocks committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    d2915d6 View commit details
    Browse the repository at this point in the history

  3. Range [UNB, CURRENT] tests. Round#1.

    @mythrocks
    mythrocks committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    917fa07 View commit details
    Browse the repository at this point in the history

  4. Fixed verify errors. 

    Signed-off-by: MithunR <[email protected]>
    @mythrocks
    mythrocks committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    b8bec1b View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. Merge remote-tracking branch 'origin/branch-23.12' into batched-range… 

    …-window-first
    @mythrocks
    mythrocks committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    3ba6480 View commit details
    Browse the repository at this point in the history

  2. More comprehensive RANGE window tests.

    @mythrocks
    mythrocks committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    22aaf7c View commit details
    Browse the repository at this point in the history

  3. Revert "More comprehensive RANGE window tests." 

    This reverts commit 22aaf7c.

Best not combine the running window ROW/RANGE tests.
    @mythrocks
    mythrocks committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    f6f6c62 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. Separate tests for ROWS and RANGE, with repeated rows in order-by.

    @mythrocks
    mythrocks committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    2d8eb65 View commit details
    Browse the repository at this point in the history

  2. Partitioned test for batched RANGE query. 

    Signed-off-by: MithunR <[email protected]>
    @mythrocks
    mythrocks committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    d9540f9 View commit details
    Browse the repository at this point in the history

  3. Partitioned tests for batched range window functions. 

    Signed-off-by: MithunR <[email protected]>
    @mythrocks
    mythrocks committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    9b1ac51 View commit details
    Browse the repository at this point in the history