This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Fix 32-bit MSVC builds. #1582
Merged
Fix 32-bit MSVC builds. #1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CUDA runtime functions are annotated with CUDARTAPI, which expands to __stdcall on MSVC. `thrust/system/cuda/memory_resource.h` defines some function pointer types intended for use with CUDART memory allocation/deallocation functions, but they lack the CUDARTAPI markup. Added this markup to fix 32-bit builds. Repro'd issue and validated fix on MSVC 2019. Fixes NVIDIA#1458.
|
DVS CL: 30787474 run tests |
alliepiper
added
testing: gpuCI in progress
gevtushenko
approved these changes
Dec 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CUDA runtime functions are annotated with CUDARTAPI, which expands to
__stdcall on MSVC.
thrust/system/cuda/memory_resource.hdefines somefunction pointer types intended for use with CUDART memory
allocation/deallocation functions, but they lack the CUDARTAPI markup.
Added this markup to fix 32-bit builds. Repro'd issue and validated
fix on MSVC 2019.
Fixes #1458.