Cross-platform-ify #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is part of a process to make cross-platform with windows ... It is turning out to be a bit more work than I intended...
This was causing a conflict with a windows header. https://cplusplus.com/forum/general/282167/
|
Problem with thrust and CUDA when building 32-bit with MSVC, apparently. |
Based on SO post given in header of `clock_gettime_windows.h`, this fix tries to allow for timing in a more cross-platform manner. This is a stop-gap solution, really.
Again, this could be better done. But I wanted to just get things to work for now.
Based on https://stackoverflow.com/questions/45013977/random-shuffle-is-not-a-member-of-std-error `random_shuffle()` was actually deprecated. How I have gotten this far without errors, I am very unsure. This seems to work.
How did I get by without this issue before?
Not sure if this is necessary, but it seems that without this, the compilation fails. ¯\_(ツ)_/¯
Needed due to my extensive use of templates, I think...
This is really just a local thing, but I'm committing just for records, I guess?
This has not been determined to be necessary, but will ultimately not be used due to next commit...
I have some terrible issue getting the `force_global_load()` function to work correctly. Since the work I am trying to do on Windows is just restructuring the "business logic" of the benchmark driver, and I plan to use that base code in the spmv anyways, I don't feel that I need to update the spmv during this work.
...I think...
Based on compiler used. Don't build with MSVC, basically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To facilitate using my favored dev environment (i.e. VSCode, with a plethora of useful extensions), I needed to be able to develop on my gaming laptop instead of the HPC machines I had been working on (as I can't do SSH tunneling to use VS Code Remote Development).
These changes are therefore an attempt to get the repository able to execute on my Windows environment.
Currently using cmake 3.24.2.
Installed the most recent version of the CUDA Toolkit.
I have the Visual Studio 2019 Community edition on my computer (using compilers for its "amd64" kit).
There were several other issues I found when setting this up, and I will try to document them in this request or in the corresponding commits.