Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Openshift no instantclient #28

Merged
merged 98 commits into from
Oct 23, 2024
Merged

Openshift no instantclient #28

merged 98 commits into from
Oct 23, 2024

Conversation

ammsalme
Copy link
Contributor

@ammsalme ammsalme commented Oct 21, 2024 •
edited
Loading

  • Node v14 -> v18
  • Add GitHubActions
  • Update .gitignore
  • Do not publish to quay.io
  • Update Dockerfile
  • Delete drone
  • Update dependencies
  • Update copyright year

Update Oracle connections:

  • Use oracledb thin mode with just oracle connectstring, without instantclient and oracle libraries
  • Use original node-oracledb instead of @natlibfi/oracledb-aleph (probably temporary)

Parse record just once

  • Parse records from dbResults just once using noFailValidation, error invalid records based on validationErrors
  • Update marc-record-js and marc-record-serializers to versions that have noFailValidation and validationErrors

Misc. updates in functionality

  • Update record formatting
  • Update all Aleph internal library prefixes to standard ISIL code based prefixes
  • Delete possible existing f003 before creating a new f003 ISIL code
  • Update aut-works context
  • Add aut-aux context
  • Fix field 275 removal
  • Add empty result error

Misc. updates in code

  • Rename function to create dbResultString data from marc-records (formatRecord -> dbDataStringFromRecord
  • Do not strigify req
  • Fix eslint-disables after eslint update

Update tests:

  • Add tests for replacePrefixes
  • Fix some tests
  • Add tests for invalid records
  • Add npm scripts for non-parallel testing (to use .only when developing)

Update logging:

  • Update logging
  • Add some debug and debugDev

natlibfi-jonollil and others added 30 commits January 17, 2023 09:13
@natlibfi-jonollil
github actions
42ee1dc
@natlibfi-jonollil
update-deps
c9a9596
@ammsalme
Add autWorks
e9a8834
@ammsalme
'Fix' drone
d5dfa35
@ammsalme
'Fix' drone 2
9273609
@ammsalme
'Fix' drone 3
5386662
@ammsalme
Update fixugen-http-server
58a0002
@natlibfi-jonollil
update deps
13c6c9e
@natlibfi-jonollil
sanitize query params
74e14eb
@natlibfi-jonollil
sanitize query params
d023eae
@natlibfi-jonollil
sanitize query params
717884f
@ammsalme
Add autWorks context
7cb9632
@ammsalme
Update record formatting
0349ff8 
* Update all Aleph internal library prefixes to standard ISIL code based prefixes
* Delete possible existing f003 before creating a new f003 ISIL code
@ammsalme
Update aut-works
c79506d
@ammsalme
Update copyright year
fc37e45
@ammsalme
Fix error
5229989
@ammsalme
Fix tests
7935c01
@ammsalme
Add tests for replacePrefixes
07eb682
@ammsalme
Add autAux context
d8f1168
@ammsalme
Update copyright year
ec8ef5d
@ammsalme
Merge branch 'add-aut-works' into fix-lib-to-isil
37d85ff
@ammsalme
Update node v12 -> v16 in Dockerfile
46f9adc
@ammsalme
Return .drone.yml
8e0ebf4
@ammsalme
Merge pull request #16 from NatLibFi/fix-lib-to-isil
30d2b3c 
Fix lib to isil
@natlibfi-jonollil
maintenace update and fix 275 field removal
2fd167e
@natlibfi-jonollil
maintenace update
45153c4
@natlibfi-jonollil
fix drone npm build
548e0e7
@natlibfi-jonollil
fix drone npm build
d117f87
@natlibfi-jonollil
fix drone npm build
af49db3
@ammsalme
Maintenance update (#17)
7239efb 
* Node v14 -> v18

* Remove rebase dependencies

* Update deps

* Fix eslint-disables after update


* 2.0.0-alpha.2
@ammsalme
Openshift test (#24)
bcc0ed6 
* Node-tests: remove v16, v19; add v20, v22
* Do not strigify req
* Add empty result error
* Update logging
@ammsalme
Fix Identify (#25)
b2cc1c2
@ammsalme
Add to .gitignore
1740dbe
@ammsalme
Fix test to work with updated marc-record-js
775e0e9
@ammsalme
Update copyright year
fea05a3
@ammsalme
Update dockerfile
7f5389e
@ammsalme
No quay.io publishing
5c7b89b
@ammsalme
Edit oracledb deps
6799939
@ammsalme
Logs
523c969
@ammsalme
TEMP: no tests
84f062a
@ammsalme
Logging
d8aee19
@ammsalme
Logging/debug
828ee12
@ammsalme
Add debug
aa53e0c
@ammsalme
Use debugDev
33732da
@ammsalme
Parse record just once
f1d18a7
@ammsalme
Update marc-record-serializers+marc-record
de4018e
@ammsalme
9.1.0-alpha.3
a35df39
@ammsalme
Add debug
138edd6
@ammsalme
Start handling record validationErrors
65273d0
@ammsalme
Updates to record parsing
750fdf9 
- Rename function to create dbResultString data from marc-records (formatRecord -> dbDataStringFromRecord)
- Parse records from dbResults just once using noFailValidation, error invalid records based on validationErrors
-- update marc-record-js and marc-record-serializers to versions that have noFailValidation and validationErrors
- Add tests for invalid records
- Add debug and debugDev
- Add npm scripts for non-parallel testing (to use only)
- Update deps
- Use original node-oracledb instead of @natlibfi/oracledb-aleph (probably temporary)
@ammsalme
Return npm run test to GitHubActions
893f8c9
@ammsalme
9.1.0-alpha.4
304978d
@ammsalme
debug -> debugDev
2670fa5
@ammsalme
Fix errors
9563d8c
@ammsalme
Delete drone
98dbec3
@natlibfi-jonollil natlibfi-jonollil changed the base branch from master to test October 23, 2024 10:22
@natlibfi-jonollil natlibfi-jonollil merged commit 081371f into test Oct 23, 2024
6 checks passed
@natlibfi-jonollil natlibfi-jonollil deleted the openshift-no-instantclient branch October 23, 2024 11:43
@ammsalme ammsalme mentioned this pull request Nov 12, 2024
Merged
ammsalme added a commit that referenced this pull request Nov 13, 2024
@ammsalme
Openshift updates ; Dependency & Maintenance update (#31)
4e74d05 
* Openshift no instantclient (#28)

* Node v14 -> v18
* Add GitHubActions
* Update .gitignore
* Do not publish to quay.io
* Update Dockerfile
* Delete drone
* Update dependencies
* Update copyright year

Update Oracle connections:
* Use oracledb thin mode with just oracle connectstring, without instantclient and oracle libraries 
* Use original node-oracledb instead of @natlibfi/oracledb-aleph (probably temporary)

Parse record just once
* Parse records from dbResults just once using noFailValidation, error invalid records based on validationErrors
* Update marc-record-js and marc-record-serializers to versions that have noFailValidation and validationErrors

Misc. updates in functionality
* Update record formatting
* Update all Aleph internal library prefixes to standard ISIL code based prefixes
* Delete possible existing f003 before creating a new f003 ISIL code
* Update aut-works context
* Add aut-aux context
* Fix field 275 removal
* Add empty result error

Misc. updates in code
* Rename function to create dbResultString data from marc-records (formatRecord -> dbDataStringFromRecord
* Do not strigify req
* Fix eslint-disables after eslint update 

Update tests:
* Add tests for replacePrefixes
* Fix some tests
* Add tests for invalid records
* Add npm scripts for non-parallel testing (to use .only when developing)

Update logging:
* Update logging
* Add some debug and debugDev

* Test resumption token with from,  (#30)

* Add test for resumptionToken with from-parameter
* Add logRows

* Use z13 instead of z106 (#32)

* Update SQL-queries
** Fix queries to use Aleph table z13 instead of Aleph table z106 
** Update fetch limit to  +1 rows (to ascertain that we get a resumption token)
** Refactor query.js
** Add first tests for query.js

* Validate for controlCharacters in record before trying to clean them

* Update logging/debug
** Add logLabels to logs and debug to identify requests

* Try to handle ORA-01103

* Update deps

* Update dockerfile
** Add python to dockerfile

* Add examples: env and sets.json
* Update license to MIT
* Update dependabot



* v2.0.0-alpha.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ammsalme @natlibfi-jonollil