Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openshift updates ; Dependency & Maintenance update #31

Merged
merged 36 commits into from
Nov 13, 2024
Merged

Openshift updates ; Dependency & Maintenance update #31

merged 36 commits into from
Nov 13, 2024

Conversation

ammsalme
Copy link
Contributor

@ammsalme ammsalme commented Oct 24, 2024

  • Openshift no instantclient (Openshift no instantclient #28)

  • Node v14 -> v18

  • Add GitHubActions

  • Update .gitignore

  • Do not publish to quay.io

  • Update Dockerfile

  • Delete drone

  • Update dependencies

  • Update copyright year

Update Oracle connections:

  • Use oracledb thin mode with just oracle connectstring, without instantclient and oracle libraries
  • Use original node-oracledb instead of @natlibfi/oracledb-aleph (probably temporary)

Parse record just once

  • Parse records from dbResults just once using noFailValidation, error invalid records based on validationErrors
  • Update marc-record-js and marc-record-serializers to versions that have noFailValidation and validationErrors

Misc. updates in functionality

  • Update record formatting
  • Update all Aleph internal library prefixes to standard ISIL code based prefixes
  • Delete possible existing f003 before creating a new f003 ISIL code
  • Update aut-works context
  • Add aut-aux context
  • Fix field 275 removal
  • Add empty result error

Misc. updates in code

  • Rename function to create dbResultString data from marc-records (formatRecord -> dbDataStringFromRecord
  • Do not strigify req
  • Fix eslint-disables after eslint update

Update tests:

  • Add tests for replacePrefixes
  • Fix some tests
  • Add tests for invalid records
  • Add npm scripts for non-parallel testing (to use .only when developing)

Update logging:

  • Update logging

  • Add some debug and debugDev

  • Test resumption token with from, (Test resumption token with from,  #30)

  • Add test for resumptionToken with from-parameter

  • Add logRows

  • Use z13 instead of z106 (Use z13 instead of z106 #32)

  • Update SQL-queries
    ** Fix queries to use Aleph table z13 instead of Aleph table z106
    ** Update fetch limit to +1 rows (to ascertain that we get a resumption token)
    ** Refactor query.js
    ** Add first tests for query.js

  • Validate for controlCharacters in record before trying to clean them

  • Update logging/debug
    ** Add logLabels to logs and debug to identify requests

  • Try to handle ORA-01103

  • Update deps

  • Update dockerfile
    ** Add python to dockerfile

  • Add examples: env and sets.json

  • Update license to MIT

  • Update dependabot



* v2.0.0-alpha.8

* Node v14 -> v18
* Add GitHubActions
* Update .gitignore
* Do not publish to quay.io
* Update Dockerfile
* Delete drone
* Update dependencies
* Update copyright year

Update Oracle connections:
* Use oracledb thin mode with just oracle connectstring, without instantclient and oracle libraries 
* Use original node-oracledb instead of @natlibfi/oracledb-aleph (probably temporary)

Parse record just once
* Parse records from dbResults just once using noFailValidation, error invalid records based on validationErrors
* Update marc-record-js and marc-record-serializers to versions that have noFailValidation and validationErrors

Misc. updates in functionality
* Update record formatting
* Update all Aleph internal library prefixes to standard ISIL code based prefixes
* Delete possible existing f003 before creating a new f003 ISIL code
* Update aut-works context
* Add aut-aux context
* Fix field 275 removal
* Add empty result error

Misc. updates in code
* Rename function to create dbResultString data from marc-records (formatRecord -> dbDataStringFromRecord
* Do not strigify req
* Fix eslint-disables after eslint update 

Update tests:
* Add tests for replacePrefixes
* Fix some tests
* Add tests for invalid records
* Add npm scripts for non-parallel testing (to use .only when developing)

Update logging:
* Update logging
* Add some debug and debugDev
* Add test for resumptionToken with from-parameter
* Add logRows
- use hopefully faster queries
- fetch limit + 1 rows (to ascertain that we get a resumption token)
- refactor query.js
package.json Outdated Show resolved Hide resolved
@ammsalme ammsalme changed the title Test Openshift updates ; Dependency & Maintenance update Nov 12, 2024
@ammsalme ammsalme marked this pull request as ready for review November 12, 2024 14:43
.github/dependabot.yml Show resolved Hide resolved
@ammsalme ammsalme merged commit 4e74d05 into main Nov 13, 2024
13 checks passed
@ammsalme ammsalme deleted the test branch November 13, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants