Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated NuGet packaging for VS 2019 #58

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Haarmees
Copy link

Hello,
While testing for #57 I wanted to be able to publish the plugin to a local feed and import it from there. I don't have VS 2017 so I wasn't able to use nugetizer3000. That's why I changed the Plugin.AudioRecorder.NuGet project to work with msbuild /t:pack and I thought I'd share it here. As an example I used https://docs.microsoft.com/en-us/nuget/guides/create-packages-for-xamarin.

With this update you should be able to right click the nuget project and click "pack". The *.nupkg file can then be found in the bin folder and published. You can also use msbuild /t:pack from the command line.

@Haarmees
Copy link
Author

@NateRickard Thanks again for this plugin. Will you be able to merge this and the other PRs? The plugin still seems pretty popular. If you want I can help with maintaining this plugin.

@NateRickard
Copy link
Owner

Thanks for the ping... I'm definitely interested in this PR - I lost my xplat setup that was configured to use the Nugetizer, and I hadn't found the time to update to something like this. I'm not working in mobile anymore, so if you're using the plugin and can help review PRs, issues, etc. I'd definitely be open to that!

@Haarmees
Copy link
Author

I'm glad to help. I'm currently planning to use the plugin at work, with the adjustments from #57. (We are recording sensitive data, so we rather not store it on the device.) I also have access to an iPhone and android devices, so testing new code shouldn't be a problem.

@NateRickard NateRickard self-requested a review April 21, 2021 01:10
@NateRickard
Copy link
Owner

NateRickard commented Apr 29, 2021

I was hoping that VS Mac could load your updated packaging solution, but alas it doesn't support that project type. I no longer have my Windows machine, so I'll have to configure a VM to get this approved, merged, and get a package out.

@Haarmees
Copy link
Author

Haarmees commented May 6, 2021

Yeah, I don't think you can build UWP on mac. I do have a windows machine available, so I could build it if you want. You can also contact me on discord haarmees#9624 if that is easier.

@LGE-AUGMENSYS
Copy link

@NateRickard @Haarmees Many thanks for your effort. Just want to ask if there's any update on this. We encountered this bug also on some other devices and it got fixed by #43. So it would be great to get an update of the Nuget package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants