Feat: remove relayer and fee #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birchmd
reviewed
Feb 10, 2023
There was a problem hiding this comment.
The change to the contract itself looks good. The change to the tests I'm less sure about though. Seems like it is creating excess noise in the code to always to a transfer to the contract (which is now effectively taking the role of a fee). I think it would be cleaner to remove the transfer to the contract instead. In tests where two token holders are needed then I think it would be better to explicitly create a second user.
@birchmd the reason is only one, the contract has 0 balance and for that, we should deposit (or transfer) some funds to the contract. |
…or into feat/remove-relayer-and-fee
birchmd
approved these changes
Feb 21, 2023
aleksuss
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As not used and redundant logic, should be removed:
feeandrelayer. It's more important fordepositflow.Audit report relations
relater_idfield issuefeecalculation issueHow to review
Pay attention to
depositmethod.Gas cost
Not change.
Tests
Fixed and refactored all tests related to
feeandrelayerlogic.Added special feature for long-time tests (drastically decreased testing time for development)