feat: Harvest should collect cloud targets #1836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - ^authentication_type => authentication_type | ||
| - ^access_key => access_key | ||
| - ^certificate_validation_enabled => certificate_validation_enabled | ||
| - ^ssl_enabled => ssl_enabled |
There was a problem hiding this comment.
Add scope also?
If the cloud target is owned by a data SVM, then the scope is set to svm. Otherwise it will be set to cluster.
| - ^provider_type => provider_type | ||
| - ^server => server | ||
| - ^authentication_type => authentication_type | ||
| - ^access_key => access_key |
There was a problem hiding this comment.
is it safe to expose access_key of an s3 bucket? Customer may not want to do that.
|
What is the link git issue for this? |
Hardikl
previously approved these changes
Mar 21, 2023
rahulguptajss
previously approved these changes
Mar 21, 2023
rahulguptajss
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.