Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Harvest should collect cloud targets #1836

Merged
merged 3 commits into from
Mar 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions conf/rest/9.11.0/cloud_target.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@

name: CloudTarget
query: api/cloud/targets
object: cloud_target

counters:
- ^^uuid => uuid
- ^name => name
- ^container => container
- ^ipspace.name => ipspace
- ^owner => owner
- ^port => port
- ^provider_type => provider_type
- ^server => server
- ^authentication_type => authentication_type
- ^access_key => access_key
- ^certificate_validation_enabled => certificate_validation_enabled
- ^ssl_enabled => ssl_enabled
- used => used

export_options:
instance_keys:
- name
- container
- server
instance_labels:
- ipspace
- owner
- port
- provider_type
- authentication_type
- access_key
- certificate_validation_enabled
- ssl_enabled
36 changes: 36 additions & 0 deletions conf/rest/9.12.0/cloud_target.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@

name: CloudTarget
query: api/cloud/targets
object: cloud_target

counters:
- ^^uuid => uuid
- ^name => name
- ^container => container
- ^ipspace.name => ipspace
- ^owner => owner
- ^port => port
- ^provider_type => provider_type
- ^server => server
- ^authentication_type => authentication_type
- ^access_key => access_key
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it safe to expose access_key of an s3 bucket? Customer may not want to do that.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it is public

- ^certificate_validation_enabled => certificate_validation_enabled
- ^ssl_enabled => ssl_enabled
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add scope also?

If the cloud target is owned by a data SVM, then the scope is set to svm. Otherwise it will be set to cluster.

- ^scope => scope
- used => used

export_options:
instance_keys:
- name
- container
- server
instance_labels:
- ipspace
- owner
- port
- provider_type
- authentication_type
- access_key
- certificate_validation_enabled
- ssl_enabled
- scope
1 change: 1 addition & 0 deletions conf/rest/default.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ schedule:

objects:
Aggr: aggr.yaml
CloudTarget: cloud_target.yaml
ClusterPeer: clusterpeer.yaml
Disk: disk.yaml
Lun: lun.yaml
Expand Down