Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assess behavior of BreadthFirstSearch on mixed directed/undirected graphs #92

Closed
nicolaspayette opened this issue Oct 17, 2013 · 1 comment
Assignees
Labels
Milestone

Comments

@nicolaspayette
Copy link
Member

Having to do 11b7434 to preserve behavior after fc7a997 while working on #91 made me wonder if the current behavior was correct.

Presently, unless a graph context is directed (i.e., unless the context is set to use a directed link breed), only undirected links are followed by BFS. We probably want to be smarter about that and follow undirected links and links in the right direction.

@ghost ghost assigned nicolaspayette Oct 17, 2013
nicolaspayette referenced this issue Oct 17, 2013
Not entirely sure that is the right thing to do, though. Will open ticket.
nicolaspayette added a commit that referenced this issue Oct 28, 2013
@nicolaspayette
Copy link
Member Author

65b1a0e makes unweighted path finding (path-to, turtles-on-path-to) follow both undirected links and directed out links. A user wanting to follow only undirected links can set the context accordingly.

2a3d061 makes the behavior of turtles-in-radius coherent with path finding primitives. I have added a turtles-in-undirected-radius to get the old behavior, but I am not entirely sure it was the right thing to do, since this can be achieved with the proper context. Maybe we should just have turtles-in-radius and turtles-in-reverse-radius and handle everything else with set-context. I think it would be simpler overall.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant