Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit in-radius primitives to turtles-in-radius and turtles-in-reverse-radius #94

Closed
nicolaspayette opened this issue Oct 28, 2013 · 0 comments
Assignees
Milestone

Comments

@nicolaspayette
Copy link
Member

In #92, I wrote:

2a3d061 makes the behavior of turtles-in-radius coherent with path finding primitives. I have added a turtles-in-undirected-radius to get the old behavior, but I am not entirely sure it was the right thing to do, since this can be achieved with the proper context. Maybe we should just have turtles-in-radius and turtles-in-reverse-radius and handle everything else with set-context. I think it would be simpler overall.

turtles-in-radius follows both undirected and directed out links.

turtles-in-reverse-radius would follow both undirected and directed in links.

Either undirected or directed links could be excluded from the search by setting the context to ignore.

It would get rid of turtles-in-in-radius and turtles-in-out-radius whose are a tiny bit confusing anyway, as well as the newly added turtles-in-undirected-radius.

The only case that would not be covered by the turtles-in-radius/turtles-in-reverse-radius would be something like turtles-in-radius-both-directions, but I am not sure if it's worth adding the latter. Opinions welcome.

I know it seems like a significant change this close to release but:

  • the next release, given the switch to set-context, is full of breaking changes anyway;
  • it's now or never;
  • it's actually trivial to implement following 65b1a0e. Writing tests and documenting the change will take the longest, and even that won't be long.

Unless given a compelling reason not to, I think I'll go forward with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant