Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PSUPCLPL-9491] Masked templates in plugins breakage #145

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

ilia1243
Copy link
Contributor

@ilia1243 ilia1243 commented Apr 14, 2022

Description

Masked templates (*) in plugins installation procedure process only the first found file.

Solution

Breakage after #74. Installation procedure returns after first processed file. Revert the change.

How to apply

Reproduced for new installed plugins.

Test Cases

TestCase 1

Test Configuration:

  • Hardware: Any
  • OS: Any
  • Inventory: any plugin with template installation procedure type, whose source is masked (*) and identifies two or more files.
    Steps:
  1. Run install.

Results:

Before After
Only one file identified by source is applied All files identified by source are applied

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Integration CI passed
  • Unit tests. If Yes list of new/changed tests with brief description
  • There is no merge conflicts

Unit tests

Changed TestTemplate.test_apply_template. Now it counts all applied files and verifies them.

Reviewers

@koryaga @iLeonidze @Zaborin @alexarefev @Yaroslav-Lahtachev @dmyar21

@ilia1243 ilia1243 added the bug Something isn't working label Apr 14, 2022
@koryaga koryaga self-requested a review April 14, 2022 11:51
@koryaga koryaga merged commit bbe864a into main Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants