-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MANOPD-70719] Verify plugins restart after template applying #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iLeonidze
force-pushed
the
manopd70719
branch
from
December 10, 2021 00:15
eb78c41
to
20b7563
Compare
iLeonidze
force-pushed
the
manopd70719
branch
from
December 10, 2021 08:05
20b7563
to
be89a6a
Compare
iLeonidze
force-pushed
the
manopd70719
branch
from
December 10, 2021 17:01
1d6e7da
to
cd025e0
Compare
koryaga
requested review from
Yaroslav-Lahtachev
and removed request for
theboringstuff
December 20, 2021 12:17
Yaroslav-Lahtachev
approved these changes
Dec 21, 2021
iLeonidze
requested review from
theboringstuff and
Yaroslav-Lahtachev
and removed request for
theboringstuff and
Yaroslav-Lahtachev
December 27, 2021 20:28
Please review this PR again after major improvements |
alexarefev
reviewed
Dec 28, 2021
iLeonidze
force-pushed
the
manopd70719
branch
from
January 11, 2022 08:01
9098561
to
a0b68e0
Compare
iLeonidze
force-pushed
the
manopd70719
branch
from
January 11, 2022 08:03
a0b68e0
to
bf259b6
Compare
@iLeonidze what if pods have always the same names (like they do for statefulsets)? |
iLeonidze
changed the title
[MANOPD-70719] Verify plugins restart after template applying
[DRAFT][MANOPD-70719] Verify plugins restart after template applying
Jan 14, 2022
After some discussion, we decided to rework this PR |
iLeonidze
force-pushed
the
manopd70719
branch
2 times, most recently
from
January 25, 2022 12:43
c5882a5
to
bbaacd3
Compare
iLeonidze
force-pushed
the
manopd70719
branch
from
January 25, 2022 12:49
bbaacd3
to
8651258
Compare
dmyar21
force-pushed
the
main
branch
2 times, most recently
from
January 26, 2022 12:01
aa51ab4
to
59d8578
Compare
iLeonidze
changed the title
[DRAFT][MANOPD-70719] Verify plugins restart after template applying
[MANOPD-70719] Verify plugins restart after template applying
Jan 27, 2022
# Conflicts: # kubemarine/resources/configurations/globals.yaml
koryaga
reviewed
Jan 27, 2022
tested on local qa env. Upgrade procedures finish successfully. issue with the calico plugin not reproduced. |
koryaga
reviewed
Feb 7, 2022
koryaga
approved these changes
Feb 8, 2022
alku89
approved these changes
Feb 8, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes MANOPD-70719
Solution
How to apply
Test Cases
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
TestCase 1
Test Configuration:
Steps:
Results:
Checklist
Unit tests
No new unit tests
Reviewers
@koryaga @iLeonidze @Zaborin @alexarefev @Yaroslav-Lahtachev @dmyar21