-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stream metrics 1.5 #1010
Stream metrics 1.5 #1010
Conversation
… to RollingNumber/RollingPercentile as well)
* Added HystrixServoMetricsPublisherCommandTest as a concrete unit test that behavior is still correct
* They get calculated only on health count intervals
…el, to thread-level. * Added global-level stream as a way to recover command-level streams
… used for HystrixCommandMetrics
…command execution stream
…adpool-rejections
(copied from comment in #981) This refactoring addresses #950. It is a large change, so I want to give the community a chance to look it over/ask questions before I start in on the 1.5.0 RC series (this will be the first commit there, if satisfactory). The main changes in this PR:
This change has not hurt performance when used in Netflix production for ~24 hours. I will publish There should be no visible change in application behavior as a result of this change (see caveats below). However, it enables future work to add new functionality. (like #333) Caveats (known differences in behavior)
Comments/questions are welcomed and encouraged. |
NetflixOSS » Hystrix » Hystrix-pull-requests #276 FAILURE |
NetflixOSS » Hystrix » Hystrix-pull-requests #278 FAILURE |
…hreadpools can both share them
… to thread pools as well
NetflixOSS » Hystrix » Hystrix-pull-requests #284 FAILURE |
NetflixOSS » Hystrix » Hystrix-pull-requests #285 FAILURE |
NetflixOSS » Hystrix » Hystrix-pull-requests #286 FAILURE |
NetflixOSS » Hystrix » Hystrix-pull-requests #287 SUCCESS |
Closed in favor of rebased #1029 |
Rebased #981 and #986 against master