Command metrics modeled as a stream #981
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 18 commits
November 17, 2015 10:05
… to RollingNumber/RollingPercentile as well)
* Added HystrixServoMetricsPublisherCommandTest as a concrete unit test that behavior is still correct
* They get calculated only on health count intervals
…el, to thread-level. * Added global-level stream as a way to recover command-level streams
… used for HystrixCommandMetrics
|
NetflixOSS » Hystrix » Hystrix-pull-requests #254 FAILURE |
|
NetflixOSS » Hystrix » Hystrix-pull-requests #255 SUCCESS |
This was referenced Nov 17, 2015
Closed
|
Closed in favor of #1010, which is rebased against HEAD of master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactoring addresses #950. It is a large change, so I want to give the community a chance to look it over/ask questions before I start in on the 1.5.0 RC series (this will be the first commit there, if satisfactory).
The main changes in this PR:
HystrixRollingNumber/HystrixRollingPercentiledata structures, they now write to aSubjectthat models a stream of command execution events.HystrixCommandMetricsnow consumes this stream in 4 ways:This change has not hurt performance when used in Netflix production for ~24 hours. I will publish
jmhresults here as well. I'll also start linking more Github issues to this ticket as I build on this work.There should be no visible change in application behavior as a result of this change (see caveats below). However, it enables future work to add new functionality. (like #333)
Caveats (known differences in behavior)
HystrixCommandMetrics#getRollingMaxConcurrentExecutions)HdrHistogramis used for latency distributions. Percentile calculation is different fromHystrixRollingPercentile.Histograms is allocated. This is currently hardcoded to 1000 objects. It's an area I want to explore more deeplyComments/questions are welcomed and encouraged.