add age reference attribute #525
Conversation
|
Would this PR also include the lower/upper bounds or ranges? |
|
Also linking: NeurodataWithoutBorders/nwbinspector#209 |
|
@CodyCBakerPhD this PR is solely to handle gestational age. I feel those issues are orthogonal so I'm making separate PRs. Also, the DANDI team wants to use "P90D/P100D" syntax to express age ranges which I think will work just as well and will not require changes to the schema (though it certainly will require changes to the NWB inspector and best practices) |
Gotcha, I'll have those ready for the session tomorrow then |
|
This maps directly to the DANDI schema: https://github.com/dandi/dandi-schema/blob/979eab30ad61afb4275f5900815ff5c9966407eb/dandischema/model_types.py#L604-L626 |
|
This looks fine to me. Please add to the release notes as well. |
| @@ -3,6 +3,11 @@ | |||
| Release Notes | |||
| ============= | |||
|
|
|||
| 2.5.1 (Upcoming) | |||
There was a problem hiding this comment.
Following version guidelines https://www.nwb.org/versioning-guidelines/ I believe this should be part of 2.6 as it adds functionality in a backward compatible way
There was a problem hiding this comment.
Please also increment the version in the namespace to 2.6.0-alpha
nwb-schema/core/nwb.namespace.yaml
Line 60 in b2fcec0
fix #412