Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add age reference attribute #525

Merged
merged 7 commits into from
Aug 16, 2022
Merged

add age reference attribute #525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7148b80
add age reference attribute
bendichter Aug 15, 2022
38aa3fb
Merge branch 'dev' into age_reference
bendichter Aug 15, 2022
cfd46d3
Update nwb.file.yaml
bendichter Aug 15, 2022
7e0405b
add default
bendichter Aug 15, 2022
30313d4
Update core/nwb.file.yaml
bendichter Aug 15, 2022
239f095
Update format_release_notes.rst
bendichter Aug 15, 2022
384c4e7
Update format_release_notes.rst
bendichter Aug 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions core/nwb.file.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,6 +450,13 @@ groups:
dtype: text
doc: Age of subject. Can be supplied instead of 'date_of_birth'.
quantity: '?'
attributes:
- name: reference
doc: "Age is with reference to this event. Can be 'birth' or
'gestational'. If reference is omitted, 'birth' is implied."
rly marked this conversation as resolved.
Show resolved Hide resolved
dtype: text
required: false
bendichter marked this conversation as resolved.
Show resolved Hide resolved
default_value: birth
- name: date_of_birth
dtype: isodatetime
doc: Date of birth of subject. Can be supplied instead of 'age'.
Expand Down
5 changes: 5 additions & 0 deletions docs/format/source/format_release_notes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@
Release Notes
=============

2.5.1 (Upcoming)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following version guidelines https://www.nwb.org/versioning-guidelines/ I believe this should be part of 2.6 as it adds functionality in a backward compatible way

----------------
- ``Subject.age`` has a new optional attribute, ``reference``, which can take a value of "birth" (default) or "gestational". (#525)


2.5.0 (June 14, 2022)
---------------------

Expand Down